Update TODO, javadoc.

This commit is contained in:
Johannes Mockenhaupt 2017-11-19 23:30:23 +01:00
parent a5ce3f85f6
commit aadb7c5728
No known key found for this signature in database
GPG key ID: 9E1EA6AF7BBBB0D1
2 changed files with 9 additions and 3 deletions

View file

@ -1,4 +1,6 @@
- [x] Bugs - [ ] Bugs
- [ ] Taking over benign warnings on connect doesn't work properly
(Notification raised but not confirmed?)
- [x] ruffy: Accessing the quick info menu yields noMenu when cartridge is low - [x] ruffy: Accessing the quick info menu yields noMenu when cartridge is low
- [x] ruffy: Multi-digit error codes in error history aren't supported - [x] ruffy: Multi-digit error codes in error history aren't supported
- [-] No connection can be established anymore; ruffy issue i can't solve - [-] No connection can be established anymore; ruffy issue i can't solve
@ -39,8 +41,8 @@
- [-] Updating time on pump - [-] Updating time on pump
- [x] Raise a warning if time clock is off - [x] Raise a warning if time clock is off
- [-] Ruffy: support reading date/time menus - [-] Ruffy: support reading date/time menus
- [-] Setting pump basal profile (20h) - [-] Setting pump basal profile
- [-] Pairing (and sourcing ruffy) (20h) - [-] Pairing (and sourcing ruffy)
- [x] Run readReservoirAndBolusLevel after SetTbr too so boluses on the pump are caught sooner? - [x] Run readReservoirAndBolusLevel after SetTbr too so boluses on the pump are caught sooner?
Currently the pump gets to know such a record when bolusing or when refresh() is called Currently the pump gets to know such a record when bolusing or when refresh() is called
after 15m of no other command taking place. IOB will then be current with next loop after 15m of no other command taking place. IOB will then be current with next loop

View file

@ -689,6 +689,10 @@ public class ComboPlugin implements PluginBase, PumpInterface, ConstraintsInterf
return commandResult; return commandResult;
} }
/**
* Returns the command result of running ReadPumpState if it wasn't successful, indicating
* an error condition. Returns null otherwise.
*/
private CommandResult runOnConnectChecks() { private CommandResult runOnConnectChecks() {
// connect, get status and check if an alarm is active // connect, get status and check if an alarm is active
CommandResult preCheckResult = ruffyScripter.readPumpState(); CommandResult preCheckResult = ruffyScripter.readPumpState();