From aadb7c57286481afff29e8f694710ee1450cec83 Mon Sep 17 00:00:00 2001 From: Johannes Mockenhaupt Date: Sun, 19 Nov 2017 23:30:23 +0100 Subject: [PATCH] Update TODO, javadoc. --- TODO-Combo.md | 8 +++++--- .../androidaps/plugins/PumpCombo/ComboPlugin.java | 4 ++++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/TODO-Combo.md b/TODO-Combo.md index 9e671f4756..a0a4300a26 100644 --- a/TODO-Combo.md +++ b/TODO-Combo.md @@ -1,4 +1,6 @@ -- [x] Bugs +- [ ] Bugs + - [ ] Taking over benign warnings on connect doesn't work properly + (Notification raised but not confirmed?) - [x] ruffy: Accessing the quick info menu yields noMenu when cartridge is low - [x] ruffy: Multi-digit error codes in error history aren't supported - [-] No connection can be established anymore; ruffy issue i can't solve @@ -39,8 +41,8 @@ - [-] Updating time on pump - [x] Raise a warning if time clock is off - [-] Ruffy: support reading date/time menus - - [-] Setting pump basal profile (20h) - - [-] Pairing (and sourcing ruffy) (20h) + - [-] Setting pump basal profile + - [-] Pairing (and sourcing ruffy) - [x] Run readReservoirAndBolusLevel after SetTbr too so boluses on the pump are caught sooner? Currently the pump gets to know such a record when bolusing or when refresh() is called after 15m of no other command taking place. IOB will then be current with next loop diff --git a/app/src/main/java/info/nightscout/androidaps/plugins/PumpCombo/ComboPlugin.java b/app/src/main/java/info/nightscout/androidaps/plugins/PumpCombo/ComboPlugin.java index facb8cc920..9c82c1a623 100644 --- a/app/src/main/java/info/nightscout/androidaps/plugins/PumpCombo/ComboPlugin.java +++ b/app/src/main/java/info/nightscout/androidaps/plugins/PumpCombo/ComboPlugin.java @@ -689,6 +689,10 @@ public class ComboPlugin implements PluginBase, PumpInterface, ConstraintsInterf return commandResult; } + /** + * Returns the command result of running ReadPumpState if it wasn't successful, indicating + * an error condition. Returns null otherwise. + */ private CommandResult runOnConnectChecks() { // connect, get status and check if an alarm is active CommandResult preCheckResult = ruffyScripter.readPumpState();