From 431e6b4311ba96edf783a1113dc5de6c78eb2c40 Mon Sep 17 00:00:00 2001 From: "Casper V. Kristensen" Date: Mon, 14 Oct 2019 12:33:21 +0200 Subject: [PATCH] GitHub: Check asset filename extension instead of content type for better reliability. --- wau/providers/github.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/wau/providers/github.py b/wau/providers/github.py index 0c51a75..b669451 100644 --- a/wau/providers/github.py +++ b/wau/providers/github.py @@ -1,5 +1,6 @@ import logging import re +from pathlib import Path from typing import Tuple from .web import Web @@ -28,7 +29,7 @@ class GitHub(Web): url=f"{cls.api_url}/repos/{repo_owner}/{repo_name}/releases/latest" ).json() for asset in latest_release["assets"]: - if asset["content_type"] == "application/x-zip-compressed": + if Path(asset["name"]).suffix == ".zip": return super().download(addon, asset["browser_download_url"]) raise FileNotFoundError("No zip file found for latest release")