From fa039e6961527f63b2c9e43d40ea16636d99ec4f Mon Sep 17 00:00:00 2001 From: Johannes Mockenhaupt Date: Sat, 15 Jul 2017 12:47:53 +0200 Subject: [PATCH] Note on cancelling TBRs that don't trigger a pump alert. --- .../de/jotomo/ruffyscripter/commands/SetTbrCommand.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/de/jotomo/ruffyscripter/commands/SetTbrCommand.java b/app/src/main/java/de/jotomo/ruffyscripter/commands/SetTbrCommand.java index 185e9974f3..013e0c642a 100644 --- a/app/src/main/java/de/jotomo/ruffyscripter/commands/SetTbrCommand.java +++ b/app/src/main/java/de/jotomo/ruffyscripter/commands/SetTbrCommand.java @@ -185,7 +185,12 @@ public class SetTbrCommand implements Command { } private void cancelTbrAndConfirmCancellationWarning(RuffyScripter scripter) { - // TODO this will fail if no TBR is running; detect and just throw CE(success=true, msg="nothing to do")? + // TODO tbr with 1m remaining doesn't raise an alert; + // BT connection is NOT lost when an alarm is raised, see if we can improve checking for + // and acknowleding errors; + // i think timing is crucial: waiting too long and the pump display activates and we lose + // connection. we can reconnect, but by then the pump might be noisy already. + // confirm entered TBR scripter.pressCheckKey();