Fix race condition on dash disconnect
This commit is contained in:
parent
7faa34aa50
commit
d5647ce021
1 changed files with 11 additions and 9 deletions
|
@ -96,7 +96,6 @@ class Connection(
|
|||
connectionWaitCond.timeoutMs = newTimeout
|
||||
}
|
||||
podState.bluetoothConnectionState = OmnipodDashPodStateManager.BluetoothConnectionState.CONNECTED
|
||||
_connectionWaitCond = null
|
||||
|
||||
val discoverer = ServiceDiscoverer(aapsLogger, gatt, bleCommCallbacks, this)
|
||||
val discovered = discoverer.discoverServices(connectionWaitCond)
|
||||
|
@ -122,21 +121,24 @@ class Connection(
|
|||
cmdBleIO.hello()
|
||||
cmdBleIO.readyToRead()
|
||||
dataBleIO.readyToRead()
|
||||
_connectionWaitCond = null
|
||||
}
|
||||
|
||||
@Synchronized
|
||||
fun disconnect(closeGatt: Boolean) {
|
||||
aapsLogger.debug(LTag.PUMPBTCOMM, "Disconnecting closeGatt=$closeGatt")
|
||||
podState.bluetoothConnectionState = OmnipodDashPodStateManager.BluetoothConnectionState.DISCONNECTED
|
||||
if (closeGatt) {
|
||||
gattConnection?.close()
|
||||
gattConnection = null
|
||||
} else {
|
||||
if (closeGatt == false && gattConnection != null) {
|
||||
// Disconnect first, then close gatt
|
||||
gattConnection?.disconnect()
|
||||
} else {
|
||||
// Call with closeGatt=true only when ble is already disconnected or there is no connection
|
||||
gattConnection?.close()
|
||||
bleCommCallbacks.resetConnection()
|
||||
gattConnection = null
|
||||
session = null
|
||||
msgIO = null
|
||||
podState.bluetoothConnectionState = OmnipodDashPodStateManager.BluetoothConnectionState.DISCONNECTED
|
||||
}
|
||||
bleCommCallbacks.resetConnection()
|
||||
session = null
|
||||
msgIO = null
|
||||
}
|
||||
|
||||
private fun waitForConnection(connectionWaitCond: ConnectionWaitCondition): ConnectionState {
|
||||
|
|
Loading…
Reference in a new issue