caspervk/AndroidAPS
1
0
Fork 0
Code Releases Activity

Rewrites CancelTempBasalPacketTest with matchers

Browse source 
Issue #2745
This commit is contained in:
Ryan Haining 2023-10-08 16:54:40 -07:00
parent 9cb7bed31a
commit d39a23977d
1 changed files with 10 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
pump/medtrum/src/test/java/info/nightscout/pump/medtrum/comm/packets/CancelTempBasalPacketTest.kt
View file

@ -1,10 +1,10 @@
package info.nightscout.pump.medtrum.comm.packets package info.nightscout.pump.medtrum.comm.packets
import com.google.common.truth.Truth.assertThat
import dagger.android.AndroidInjector import dagger.android.AndroidInjector
import dagger.android.HasAndroidInjector import dagger.android.HasAndroidInjector
import info.nightscout.pump.medtrum.MedtrumTestBase import info.nightscout.pump.medtrum.MedtrumTestBase
import info.nightscout.pump.medtrum.comm.enums.BasalType import info.nightscout.pump.medtrum.comm.enums.BasalType
import org.junit.jupiter.api.Assertions
import org.junit.jupiter.api.Test import org.junit.jupiter.api.Test
class CancelTempBasalPacketTest : MedtrumTestBase() { class CancelTempBasalPacketTest : MedtrumTestBase() {
@ -30,8 +30,7 @@ class CancelTempBasalPacketTest : MedtrumTestBase() {
val result = packet.getRequest() val result = packet.getRequest()
// Expected values // Expected values
Assertions.assertEquals(1, result.size) assertThat(result).asList().containsExactly(opCode.toByte())
Assertions.assertEquals(opCode.toByte(), result[0])
} }
@Test fun handleResponseGivenPacketWhenValuesSetThenReturnCorrectValues() { @Test fun handleResponseGivenPacketWhenValuesSetThenReturnCorrectValues() {
@ -49,12 +48,12 @@ class CancelTempBasalPacketTest : MedtrumTestBase() {
val expectedStartTime = 1679575392000L val expectedStartTime = 1679575392000L
val expectedPatchId = 146L val expectedPatchId = 146L
Assertions.assertTrue(result) assertThat(result).isTrue()
Assertions.assertEquals(expectedBasalType, medtrumPump.lastBasalType) assertThat(medtrumPump.lastBasalType).isEqualTo(expectedBasalType)
Assertions.assertEquals(expectedBasalRate, medtrumPump.lastBasalRate, 0.01) assertThat(medtrumPump.lastBasalRate).isWithin(0.01).of(expectedBasalRate)
Assertions.assertEquals(expectedBasalSequence, medtrumPump.lastBasalSequence) assertThat(medtrumPump.lastBasalSequence).isEqualTo(expectedBasalSequence)
Assertions.assertEquals(expectedStartTime, medtrumPump.lastBasalStartTime) assertThat(medtrumPump.lastBasalStartTime).isEqualTo(expectedStartTime)
Assertions.assertEquals(expectedPatchId, medtrumPump.lastBasalPatchId) assertThat(medtrumPump.lastBasalPatchId).isEqualTo(expectedPatchId)
} }
@Test fun handleResponseGivenResponseWhenMessageTooShortThenResultFalse() { @Test fun handleResponseGivenResponseWhenMessageTooShortThenResultFalse() {
@ -66,7 +65,7 @@ class CancelTempBasalPacketTest : MedtrumTestBase() {
val result = packet.handleResponse(response) val result = packet.handleResponse(response)
// Expected values // Expected values
Assertions.assertFalse(result) assertThat(result).isFalse()
Assertions.assertTrue(packet.failed) assertThat(packet.failed).isTrue()
} }
} }