Rewrites MidnightTimeTest with matchers

Issue #2745
This commit is contained in:
Ryan Haining 2023-09-08 19:20:39 -07:00
parent f639a78ff4
commit ce5d2dfdbd

View file

@ -1,7 +1,7 @@
package info.nightscout.core.utils package info.nightscout.core.utils
import com.google.common.truth.Truth.assertThat
import info.nightscout.interfaces.utils.MidnightTime import info.nightscout.interfaces.utils.MidnightTime
import org.junit.jupiter.api.Assertions
import org.junit.jupiter.api.Test import org.junit.jupiter.api.Test
import java.util.Calendar import java.util.Calendar
@ -10,40 +10,40 @@ class MidnightTimeTest {
@Test fun calc() { @Test fun calc() {
// We get real midnight // We get real midnight
val now = System.currentTimeMillis() val now = System.currentTimeMillis()
Assertions.assertTrue(now >= MidnightTime.calc()) assertThat(MidnightTime.calc()).isAtMost(now)
val c = Calendar.getInstance() val c = Calendar.getInstance()
c.timeInMillis = MidnightTime.calc() c.timeInMillis = MidnightTime.calc()
Assertions.assertEquals(c[Calendar.HOUR_OF_DAY].toLong(), 0) assertThat(c[Calendar.HOUR_OF_DAY].toLong()).isEqualTo(0L)
Assertions.assertEquals(c[Calendar.MINUTE].toLong(), 0) assertThat(c[Calendar.MINUTE].toLong()).isEqualTo(0L)
Assertions.assertEquals(c[Calendar.SECOND].toLong(), 0) assertThat(c[Calendar.SECOND].toLong()).isEqualTo(0L)
Assertions.assertEquals(c[Calendar.MILLISECOND].toLong(), 0) assertThat(c[Calendar.MILLISECOND].toLong()).isEqualTo(0L)
} }
@Test fun calc_time() { @Test fun calc_time() {
// We get real midnight // We get real midnight
val now = System.currentTimeMillis() val now = System.currentTimeMillis()
val midnight = MidnightTime.calc(now) val midnight = MidnightTime.calc(now)
Assertions.assertTrue(now >= midnight) assertThat(midnight).isAtMost(now)
val c = Calendar.getInstance() val c = Calendar.getInstance()
c.timeInMillis = MidnightTime.calc(now) c.timeInMillis = MidnightTime.calc(now)
Assertions.assertEquals(c[Calendar.HOUR_OF_DAY].toLong(), 0) assertThat(c[Calendar.HOUR_OF_DAY].toLong()).isEqualTo(0L)
Assertions.assertEquals(c[Calendar.MINUTE].toLong(), 0) assertThat(c[Calendar.MINUTE].toLong()).isEqualTo(0L)
Assertions.assertEquals(c[Calendar.SECOND].toLong(), 0) assertThat(c[Calendar.SECOND].toLong()).isEqualTo(0L)
Assertions.assertEquals(c[Calendar.MILLISECOND].toLong(), 0) assertThat(c[Calendar.MILLISECOND].toLong()).isEqualTo(0L)
// Assure we get the same time from cache // Assure we get the same time from cache
Assertions.assertEquals(midnight, MidnightTime.calc(now)) assertThat(midnight).isEqualTo(MidnightTime.calc(now))
} }
@Test fun resetCache() { @Test fun resetCache() {
val now = System.currentTimeMillis() val now = System.currentTimeMillis()
MidnightTime.calc(now) MidnightTime.calc(now)
MidnightTime.resetCache() MidnightTime.resetCache()
Assertions.assertEquals(0, MidnightTime.times.size().toLong()) assertThat(MidnightTime.times.size().toLong()).isEqualTo(0L)
} }
@Test fun log() { @Test fun log() {
val now = System.currentTimeMillis() val now = System.currentTimeMillis()
MidnightTime.calc(now) MidnightTime.calc(now)
Assertions.assertTrue(MidnightTime.log().startsWith("Hits:")) assertThat(MidnightTime.log()).startsWith("Hits:")
} }
} }