From 7994f2fca2fe5120b424f6e1c3bd27a1020ccfd4 Mon Sep 17 00:00:00 2001 From: TeleRiddler Date: Tue, 1 Dec 2020 21:57:03 +0100 Subject: [PATCH 1/6] Created, reworked and added new Omnipod icons with color schemes --- ...on_omnipod_overview_acknowledge_alerts.xml | 28 ++++------ .../icon_omnipod_overview_pod_management.xml | 26 ++++----- ...on_omnipod_overview_refresh_pod_status.xml | 20 +++---- .../icon_omnipod_overview_resume_delivery.xml | 19 +++---- .../icon_omnipod_overview_set_time.xml | 17 +++--- ...icon_omnipod_overview_suspend_delivery.xml | 19 +++---- ...on_pod_activity_reset_rileylink_config.xml | 24 +++++++++ .../icon_pod_management_activate_pod.xml | 19 +++---- .../icon_pod_management_deactivate_pod.xml | 19 +++---- .../icon_pod_management_discard_pod.xml | 23 ++++---- .../icon_pod_management_play_test_beep.xml | 28 ++++------ .../icon_pod_management_pod_history.xml | 16 +++--- .../icon_pod_management_pulse_log.xml | 28 +++++----- .../drawable/icon_pod_management_rl_stats.xml | 53 ++++++++----------- omnipod/src/main/res/values/colors.xml | 43 +++++++++------ 15 files changed, 186 insertions(+), 196 deletions(-) create mode 100644 omnipod/src/main/res/drawable/icon_pod_activity_reset_rileylink_config.xml diff --git a/omnipod/src/main/res/drawable/icon_omnipod_overview_acknowledge_alerts.xml b/omnipod/src/main/res/drawable/icon_omnipod_overview_acknowledge_alerts.xml index b2dc0d4aa5..35a2f6482d 100644 --- a/omnipod/src/main/res/drawable/icon_omnipod_overview_acknowledge_alerts.xml +++ b/omnipod/src/main/res/drawable/icon_omnipod_overview_acknowledge_alerts.xml @@ -1,19 +1,11 @@ - - - + + + diff --git a/omnipod/src/main/res/drawable/icon_omnipod_overview_pod_management.xml b/omnipod/src/main/res/drawable/icon_omnipod_overview_pod_management.xml index 0945446755..dc2d89cb31 100644 --- a/omnipod/src/main/res/drawable/icon_omnipod_overview_pod_management.xml +++ b/omnipod/src/main/res/drawable/icon_omnipod_overview_pod_management.xml @@ -1,13 +1,15 @@ - - - + + + + diff --git a/omnipod/src/main/res/drawable/icon_omnipod_overview_refresh_pod_status.xml b/omnipod/src/main/res/drawable/icon_omnipod_overview_refresh_pod_status.xml index 08a61b9d5e..bd3703e076 100644 --- a/omnipod/src/main/res/drawable/icon_omnipod_overview_refresh_pod_status.xml +++ b/omnipod/src/main/res/drawable/icon_omnipod_overview_refresh_pod_status.xml @@ -1,13 +1,9 @@ - - - + + + + diff --git a/omnipod/src/main/res/drawable/icon_omnipod_overview_resume_delivery.xml b/omnipod/src/main/res/drawable/icon_omnipod_overview_resume_delivery.xml index b6b95f4270..b2d89fe2da 100644 --- a/omnipod/src/main/res/drawable/icon_omnipod_overview_resume_delivery.xml +++ b/omnipod/src/main/res/drawable/icon_omnipod_overview_resume_delivery.xml @@ -1,13 +1,8 @@ - - - + + + diff --git a/omnipod/src/main/res/drawable/icon_omnipod_overview_set_time.xml b/omnipod/src/main/res/drawable/icon_omnipod_overview_set_time.xml index 5eebe9fe9a..191cddf4fb 100644 --- a/omnipod/src/main/res/drawable/icon_omnipod_overview_set_time.xml +++ b/omnipod/src/main/res/drawable/icon_omnipod_overview_set_time.xml @@ -1,10 +1,9 @@ - - + + + diff --git a/omnipod/src/main/res/drawable/icon_omnipod_overview_suspend_delivery.xml b/omnipod/src/main/res/drawable/icon_omnipod_overview_suspend_delivery.xml index 41d71799f1..73fa2635e3 100644 --- a/omnipod/src/main/res/drawable/icon_omnipod_overview_suspend_delivery.xml +++ b/omnipod/src/main/res/drawable/icon_omnipod_overview_suspend_delivery.xml @@ -1,13 +1,8 @@ - - - + + + diff --git a/omnipod/src/main/res/drawable/icon_pod_activity_reset_rileylink_config.xml b/omnipod/src/main/res/drawable/icon_pod_activity_reset_rileylink_config.xml new file mode 100644 index 0000000000..9c3da03055 --- /dev/null +++ b/omnipod/src/main/res/drawable/icon_pod_activity_reset_rileylink_config.xml @@ -0,0 +1,24 @@ + + + + + + + + + diff --git a/omnipod/src/main/res/drawable/icon_pod_management_activate_pod.xml b/omnipod/src/main/res/drawable/icon_pod_management_activate_pod.xml index 8f71e8ed1c..214384f5b6 100644 --- a/omnipod/src/main/res/drawable/icon_pod_management_activate_pod.xml +++ b/omnipod/src/main/res/drawable/icon_pod_management_activate_pod.xml @@ -1,13 +1,8 @@ - - - + + + diff --git a/omnipod/src/main/res/drawable/icon_pod_management_deactivate_pod.xml b/omnipod/src/main/res/drawable/icon_pod_management_deactivate_pod.xml index 4d742070e8..5a9b273b87 100644 --- a/omnipod/src/main/res/drawable/icon_pod_management_deactivate_pod.xml +++ b/omnipod/src/main/res/drawable/icon_pod_management_deactivate_pod.xml @@ -1,13 +1,8 @@ - - - + + + diff --git a/omnipod/src/main/res/drawable/icon_pod_management_discard_pod.xml b/omnipod/src/main/res/drawable/icon_pod_management_discard_pod.xml index 46ed403407..775704d4da 100644 --- a/omnipod/src/main/res/drawable/icon_pod_management_discard_pod.xml +++ b/omnipod/src/main/res/drawable/icon_pod_management_discard_pod.xml @@ -1,10 +1,13 @@ - - - \ No newline at end of file + + + + + diff --git a/omnipod/src/main/res/drawable/icon_pod_management_play_test_beep.xml b/omnipod/src/main/res/drawable/icon_pod_management_play_test_beep.xml index 23c94a8c8c..e80cb36475 100644 --- a/omnipod/src/main/res/drawable/icon_pod_management_play_test_beep.xml +++ b/omnipod/src/main/res/drawable/icon_pod_management_play_test_beep.xml @@ -1,20 +1,10 @@ - - - - + + + + + diff --git a/omnipod/src/main/res/drawable/icon_pod_management_pod_history.xml b/omnipod/src/main/res/drawable/icon_pod_management_pod_history.xml index 25c8eda71e..6ba8ddf5bb 100644 --- a/omnipod/src/main/res/drawable/icon_pod_management_pod_history.xml +++ b/omnipod/src/main/res/drawable/icon_pod_management_pod_history.xml @@ -1,10 +1,8 @@ - - + + + diff --git a/omnipod/src/main/res/drawable/icon_pod_management_pulse_log.xml b/omnipod/src/main/res/drawable/icon_pod_management_pulse_log.xml index 6c1874dcc6..faaa137526 100644 --- a/omnipod/src/main/res/drawable/icon_pod_management_pulse_log.xml +++ b/omnipod/src/main/res/drawable/icon_pod_management_pulse_log.xml @@ -1,13 +1,17 @@ - - - + + + + + + + + + + diff --git a/omnipod/src/main/res/drawable/icon_pod_management_rl_stats.xml b/omnipod/src/main/res/drawable/icon_pod_management_rl_stats.xml index b02dd55804..cde8412e8b 100644 --- a/omnipod/src/main/res/drawable/icon_pod_management_rl_stats.xml +++ b/omnipod/src/main/res/drawable/icon_pod_management_rl_stats.xml @@ -1,31 +1,24 @@ - - - - - + + + + + + + + diff --git a/omnipod/src/main/res/values/colors.xml b/omnipod/src/main/res/values/colors.xml index 7f355622fc..5931700c66 100644 --- a/omnipod/src/main/res/values/colors.xml +++ b/omnipod/src/main/res/values/colors.xml @@ -6,35 +6,44 @@ #77DD77 - #FFFFFFFF + #90CAF9 + #b9d2d2 + #66BB6A + #FF7043 + + + @color/rl_board_shape + @color/rl_icon_outline - #FFFFFFFF - @color/pod_icon_outline - #FFFFFFFF - @color/pod_icon_outline - #FFFFFFFF + #FF4444 @color/pod_icon_outline - #FFFFFFFF - @color/pod_icon_outline - #FFFFFFFF + #4CAF50 + @color/pod_icon_outline + @color/pod_icon_outline + #42A5F5 + @color/pod_icon_outline + #67E86A @color/pod_icon_outline - #FFFFFFFF + #B39DDB + @color/pod_icon_outline + #ffbf00 @color/pod_icon_outline - #FFFFFFFF + #67E86A @color/pod_icon_outline - #FFFFFFFF + #FF4444 @color/pod_icon_outline - #FFFFFFFF + #85F803 @color/pod_icon_outline - #FFFFFFFF + #ffbf00 @color/pod_icon_outline - #FFFFFFFF + #4DD0E1 @color/pod_icon_outline - #FFFFFFFF + #9FA8DA @color/pod_icon_outline - #FFFFFFFF + @color/rl_board_shape + @color/rl_icon_outline \ No newline at end of file From 02ce6f5c7417aa5cc369fc5a7df7ae80cfab6c49 Mon Sep 17 00:00:00 2001 From: Bart Sopers Date: Tue, 1 Dec 2020 22:49:33 +0100 Subject: [PATCH 2/6] Use custom Reset RileyLink icon for Omnipod and rename badly named local variable --- .../plugins/pump/omnipod/OmnipodPumpPlugin.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/OmnipodPumpPlugin.java b/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/OmnipodPumpPlugin.java index 5d5196caa8..9462d3ebba 100644 --- a/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/OmnipodPumpPlugin.java +++ b/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/OmnipodPumpPlugin.java @@ -141,7 +141,7 @@ public class OmnipodPumpPlugin extends PumpPluginBase implements PumpInterface, private final PumpType pumpType = PumpType.Insulet_Omnipod; private final List customActions = Collections.singletonList(new CustomAction( - R.string.omnipod_custom_action_reset_rileylink, OmnipodCustomActionType.RESET_RILEY_LINK_CONFIGURATION, true)); + R.string.omnipod_custom_action_reset_rileylink, OmnipodCustomActionType.RESET_RILEY_LINK_CONFIGURATION, R.drawable.icon_pod_activity_reset_rileylink_config, true)); private final CompositeDisposable disposables = new CompositeDisposable(); private final NSUpload nsUpload; @@ -810,12 +810,12 @@ public class OmnipodPumpPlugin extends PumpPluginBase implements PumpInterface, @Override public void executeCustomAction(CustomActionType customActionType) { - OmnipodCustomActionType mcat = (OmnipodCustomActionType) customActionType; + OmnipodCustomActionType omnipodCustomActionType = (OmnipodCustomActionType) customActionType; - if (mcat == OmnipodCustomActionType.RESET_RILEY_LINK_CONFIGURATION) { + if (omnipodCustomActionType == OmnipodCustomActionType.RESET_RILEY_LINK_CONFIGURATION) { serviceTaskExecutor.startTask(new ResetRileyLinkConfigurationTask(getInjector())); } else { - aapsLogger.warn(LTag.PUMP, "Unknown custom action: " + mcat); + aapsLogger.warn(LTag.PUMP, "Unknown custom action: " + omnipodCustomActionType); } } From b3f0a0f4bc394bc71ef93bc9701f51f5224270e8 Mon Sep 17 00:00:00 2001 From: TeleRiddler Date: Thu, 3 Dec 2020 12:01:30 +0100 Subject: [PATCH 3/6] Updated Pod Management Layout and cleaned up XML to make layout items match parent elements. Added a few dynamic text elements for Pod Management interface to strings.xml --- ...on_omnipod_overview_refresh_pod_status.xml | 2 +- .../icon_pod_management_activate_pod.xml | 2 +- .../icon_pod_management_pod_history.xml | 2 +- .../src/main/res/layout/omnipod_overview.xml | 12 - .../res/layout/omnipod_pod_management.xml | 239 +++++++++++------- omnipod/src/main/res/values/colors.xml | 2 +- omnipod/src/main/res/values/strings.xml | 2 + 7 files changed, 153 insertions(+), 108 deletions(-) diff --git a/omnipod/src/main/res/drawable/icon_omnipod_overview_refresh_pod_status.xml b/omnipod/src/main/res/drawable/icon_omnipod_overview_refresh_pod_status.xml index bd3703e076..ae004ae4fe 100644 --- a/omnipod/src/main/res/drawable/icon_omnipod_overview_refresh_pod_status.xml +++ b/omnipod/src/main/res/drawable/icon_omnipod_overview_refresh_pod_status.xml @@ -1,6 +1,6 @@ - diff --git a/omnipod/src/main/res/drawable/icon_pod_management_activate_pod.xml b/omnipod/src/main/res/drawable/icon_pod_management_activate_pod.xml index 214384f5b6..8694bbf7e2 100644 --- a/omnipod/src/main/res/drawable/icon_pod_management_activate_pod.xml +++ b/omnipod/src/main/res/drawable/icon_pod_management_activate_pod.xml @@ -1,6 +1,6 @@ - diff --git a/omnipod/src/main/res/drawable/icon_pod_management_pod_history.xml b/omnipod/src/main/res/drawable/icon_pod_management_pod_history.xml index 6ba8ddf5bb..abf666839c 100644 --- a/omnipod/src/main/res/drawable/icon_pod_management_pod_history.xml +++ b/omnipod/src/main/res/drawable/icon_pod_management_pod_history.xml @@ -1,6 +1,6 @@ - +