Rewrites SetTempBasalPacketTest with matchers

Issue #2745
This commit is contained in:
Ryan Haining 2023-10-08 18:16:12 -07:00
parent 5bfedf055c
commit b560313e75

View file

@ -1,10 +1,10 @@
package info.nightscout.pump.medtrum.comm.packets package info.nightscout.pump.medtrum.comm.packets
import com.google.common.truth.Truth.assertThat
import dagger.android.AndroidInjector import dagger.android.AndroidInjector
import dagger.android.HasAndroidInjector import dagger.android.HasAndroidInjector
import info.nightscout.pump.medtrum.MedtrumTestBase import info.nightscout.pump.medtrum.MedtrumTestBase
import info.nightscout.pump.medtrum.comm.enums.BasalType import info.nightscout.pump.medtrum.comm.enums.BasalType
import org.junit.jupiter.api.Assertions
import org.junit.jupiter.api.Test import org.junit.jupiter.api.Test
class SetTempBasalPacketTest : MedtrumTestBase() { class SetTempBasalPacketTest : MedtrumTestBase() {
@ -31,7 +31,7 @@ class SetTempBasalPacketTest : MedtrumTestBase() {
// Expected values // Expected values
val expected = byteArrayOf(24, 6, 25, 0, 60, 0) val expected = byteArrayOf(24, 6, 25, 0, 60, 0)
Assertions.assertEquals(expected.contentToString(), result.contentToString()) assertThat(result.contentToString()).isEqualTo(expected.contentToString())
} }
@Test fun handleResponseGivenPacketWhenValuesSetThenReturnCorrectValues() { @Test fun handleResponseGivenPacketWhenValuesSetThenReturnCorrectValues() {
@ -52,12 +52,12 @@ class SetTempBasalPacketTest : MedtrumTestBase() {
val expectedStartTime = 1679575112000L val expectedStartTime = 1679575112000L
val expectedPatchId = 146L val expectedPatchId = 146L
Assertions.assertTrue(result) assertThat(result).isTrue()
Assertions.assertEquals(expectedBasalType, medtrumPump.lastBasalType) assertThat(medtrumPump.lastBasalType).isEqualTo(expectedBasalType)
Assertions.assertEquals(expectedBasalRate, medtrumPump.lastBasalRate, 0.01) assertThat(medtrumPump.lastBasalRate).isWithin(0.01).of(expectedBasalRate)
Assertions.assertEquals(expectedBasalSequence, medtrumPump.lastBasalSequence) assertThat(medtrumPump.lastBasalSequence).isEqualTo(expectedBasalSequence)
Assertions.assertEquals(expectedStartTime, medtrumPump.lastBasalStartTime) assertThat(medtrumPump.lastBasalStartTime).isEqualTo(expectedStartTime)
Assertions.assertEquals(expectedPatchId, medtrumPump.lastBasalPatchId) assertThat(medtrumPump.lastBasalPatchId).isEqualTo(expectedPatchId)
} }
@Test fun handleResponseGivenResponseWhenMessageTooShortThenResultFalse() { @Test fun handleResponseGivenResponseWhenMessageTooShortThenResultFalse() {
@ -72,6 +72,6 @@ class SetTempBasalPacketTest : MedtrumTestBase() {
val result = packet.handleResponse(response) val result = packet.handleResponse(response)
// Expected values // Expected values
Assertions.assertFalse(result) assertThat(result).isFalse()
} }
} }