From aca9b3ff65f4a900be4b6c5f56c1646c1d2307ac Mon Sep 17 00:00:00 2001
From: "Markus M. May" <triplem@javafreedom.org>
Date: Mon, 30 Jul 2018 23:05:46 +0200
Subject: [PATCH] reflect code revieww

---
 .../Maintenance/MaintenancePlugin.java        | 34 ++-----------------
 .../nightscout/utils/LoggerUtilsTest.java     | 14 --------
 2 files changed, 3 insertions(+), 45 deletions(-)
 delete mode 100644 app/src/test/java/info/nightscout/utils/LoggerUtilsTest.java

diff --git a/app/src/main/java/info/nightscout/androidaps/plugins/Maintenance/MaintenancePlugin.java b/app/src/main/java/info/nightscout/androidaps/plugins/Maintenance/MaintenancePlugin.java
index bace1b2c6d..169f5b8437 100644
--- a/app/src/main/java/info/nightscout/androidaps/plugins/Maintenance/MaintenancePlugin.java
+++ b/app/src/main/java/info/nightscout/androidaps/plugins/Maintenance/MaintenancePlugin.java
@@ -4,7 +4,6 @@ import android.content.Context;
 import android.content.Intent;
 import android.net.Uri;
 import android.support.v4.content.FileProvider;
-import android.support.v7.app.AlertDialog;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -23,14 +22,10 @@ import java.util.List;
 import java.util.zip.ZipEntry;
 import java.util.zip.ZipOutputStream;
 
-import info.nightscout.androidaps.MainApp;
 import info.nightscout.androidaps.R;
 import info.nightscout.androidaps.interfaces.PluginBase;
 import info.nightscout.androidaps.interfaces.PluginDescription;
 import info.nightscout.androidaps.interfaces.PluginType;
-import info.nightscout.androidaps.plugins.Food.FoodPlugin;
-import info.nightscout.androidaps.plugins.Treatments.TreatmentsPlugin;
-import info.nightscout.utils.ImportExportPrefs;
 import info.nightscout.utils.LoggerUtils;
 import info.nightscout.utils.SP;
 
@@ -75,16 +70,6 @@ public class MaintenancePlugin extends PluginBase {
         this.ctx = ctx;
     }
 
-    @Override
-    protected void onStart() {
-        super.onStart();
-    }
-
-    @Override
-    protected void onStop() {
-
-    }
-
     public void sendLogs() {
         String recipient = SP.getString("key_maintenance_logs_email", "logs@androidaps.org");
         int amount = SP.getInt("key_maintenance_logs_amount", 2);
@@ -148,7 +133,9 @@ public class MaintenancePlugin extends PluginBase {
 
     /**
      * returns a list of log files. The number of returned logs is given via the amount
-     * parameter. The log files are sorted by the name descending.
+     * parameter.
+     *
+     * The log files are sorted by the name descending.
      *
      * @param directory
      * @param amount
@@ -184,14 +171,6 @@ public class MaintenancePlugin extends PluginBase {
         return result.subList(0, toIndex);
     }
 
-    /**
-     * Zips the given files in a zipfile which is stored in the given zipDir using the givven
-     * name.
-     *
-     * @param zipFile
-     * @param files
-     * @return
-     */
     public File zipLogs(File zipFile, List<File> files) {
         LOG.debug("creating zip {}", zipFile.getAbsolutePath());
 
@@ -216,13 +195,6 @@ public class MaintenancePlugin extends PluginBase {
         return "AndroidAPS_LOG_" + String.valueOf(new Date().getTime()) + LoggerUtils.SUFFIX;
     }
 
-    /**
-     * This method stores all given files inside the given zipFile.
-     *
-     * @param zipFile
-     * @param files
-     * @throws IOException
-     */
     public void zip(File zipFile, List<File> files) throws IOException {
         final int BUFFER_SIZE = 2048;
 
diff --git a/app/src/test/java/info/nightscout/utils/LoggerUtilsTest.java b/app/src/test/java/info/nightscout/utils/LoggerUtilsTest.java
deleted file mode 100644
index 257a27dc13..0000000000
--- a/app/src/test/java/info/nightscout/utils/LoggerUtilsTest.java
+++ /dev/null
@@ -1,14 +0,0 @@
-package info.nightscout.utils;
-
-import org.junit.Test;
-
-import java.io.File;
-import java.util.List;
-
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
-
-public class LoggerUtilsTest {
-
-
-}