diff --git a/.idea/codeStyles/Project.xml b/.idea/codeStyles/Project.xml
index 193c7c536d..bf41126f8b 100644
--- a/.idea/codeStyles/Project.xml
+++ b/.idea/codeStyles/Project.xml
@@ -4,8 +4,6 @@
-
-
diff --git a/app/src/main/java/info/nightscout/androidaps/MainActivity.kt b/app/src/main/java/info/nightscout/androidaps/MainActivity.kt
index 0abc56dbfc..9adbcafd07 100644
--- a/app/src/main/java/info/nightscout/androidaps/MainActivity.kt
+++ b/app/src/main/java/info/nightscout/androidaps/MainActivity.kt
@@ -13,6 +13,7 @@ import android.text.style.ForegroundColorSpan
import android.text.util.Linkify
import android.util.TypedValue
import android.view.Menu
+import android.view.MenuInflater
import android.view.MenuItem
import android.view.MotionEvent
import android.view.View
@@ -26,6 +27,7 @@ import androidx.appcompat.app.ActionBarDrawerToggle
import androidx.appcompat.widget.Toolbar
import androidx.core.view.GravityCompat
import androidx.core.view.MenuCompat
+import androidx.core.view.MenuProvider
import androidx.viewpager2.widget.ViewPager2
import com.google.android.material.dialog.MaterialAlertDialogBuilder
import com.google.android.material.tabs.TabLayoutMediator
@@ -165,6 +167,114 @@ class MainActivity : DaggerAppCompatActivityWithResult() {
else finish()
}
})
+ addMenuProvider(object : MenuProvider {
+ override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {
+ MenuCompat.setGroupDividerEnabled(menu, true)
+ this@MainActivity.menu = menu
+ menuInflater.inflate(R.menu.menu_main, menu)
+ pluginPreferencesMenuItem = menu.findItem(R.id.nav_plugin_preferences)
+ }
+
+ override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
+ when (menuItem.itemId) {
+ R.id.nav_preferences -> {
+ protectionCheck.queryProtection(this@MainActivity, ProtectionCheck.Protection.PREFERENCES, {
+ startActivity(
+ Intent(this@MainActivity, PreferencesActivity::class.java)
+ .setAction("info.nightscout.androidaps.MainActivity")
+ .putExtra("id", -1)
+ )
+ })
+ true
+ }
+
+ R.id.nav_historybrowser -> {
+ startActivity(Intent(this@MainActivity, HistoryBrowseActivity::class.java).setAction("info.nightscout.androidaps.MainActivity"))
+ true
+ }
+
+ R.id.nav_treatments -> {
+ startActivity(Intent(this@MainActivity, TreatmentsActivity::class.java).setAction("info.nightscout.androidaps.MainActivity"))
+ true
+ }
+
+ R.id.nav_setupwizard -> {
+ protectionCheck.queryProtection(this@MainActivity, ProtectionCheck.Protection.PREFERENCES, {
+ startActivity(Intent(this@MainActivity, SetupWizardActivity::class.java).setAction("info.nightscout.androidaps.MainActivity"))
+ })
+ true
+ }
+
+ R.id.nav_about -> {
+ var message = "Build: ${BuildConfig.BUILDVERSION}\n"
+ message += "Flavor: ${BuildConfig.FLAVOR}${BuildConfig.BUILD_TYPE}\n"
+ message += "${rh.gs(info.nightscout.configuration.R.string.configbuilder_nightscoutversion_label)} ${activePlugin.activeNsClient?.detectedNsVersion() ?: rh.gs(info.nightscout.plugins.R.string.not_available_full)}"
+ if (config.isEngineeringMode()) message += "\n${rh.gs(info.nightscout.configuration.R.string.engineering_mode_enabled)}"
+ if (config.isUnfinishedMode()) message += "\nUnfinished mode enabled"
+ if (!fabricPrivacy.fabricEnabled()) message += "\n${rh.gs(info.nightscout.core.ui.R.string.fabric_upload_disabled)}"
+ message += rh.gs(info.nightscout.core.ui.R.string.about_link_urls)
+ val messageSpanned = SpannableString(message)
+ Linkify.addLinks(messageSpanned, Linkify.WEB_URLS)
+ MaterialAlertDialogBuilder(this@MainActivity, info.nightscout.core.ui.R.style.DialogTheme)
+ .setTitle(rh.gs(R.string.app_name) + " " + BuildConfig.VERSION)
+ .setIcon(iconsProvider.getIcon())
+ .setMessage(messageSpanned)
+ .setPositiveButton(rh.gs(info.nightscout.core.ui.R.string.ok), null)
+ .setNeutralButton(rh.gs(info.nightscout.core.ui.R.string.cta_dont_kill_my_app_info)) { _, _ ->
+ startActivity(
+ Intent(
+ Intent.ACTION_VIEW,
+ Uri.parse("https://dontkillmyapp.com/" + Build.MANUFACTURER.lowercase().replace(" ", "-"))
+ )
+ )
+ }
+ .create().apply {
+ show()
+ findViewById(android.R.id.message)?.movementMethod = LinkMovementMethod.getInstance()
+ }
+ true
+ }
+
+ R.id.nav_exit -> {
+ aapsLogger.debug(LTag.CORE, "Exiting")
+ uel.log(Action.EXIT_AAPS, Sources.Aaps)
+ rxBus.send(EventAppExit())
+ finish()
+ System.runFinalization()
+ exitProcess(0)
+ }
+
+ R.id.nav_plugin_preferences -> {
+ val plugin = (binding.mainPager.adapter as TabPageAdapter).getPluginAt(binding.mainPager.currentItem)
+ protectionCheck.queryProtection(this@MainActivity, ProtectionCheck.Protection.PREFERENCES, {
+ startActivity(
+ Intent(this@MainActivity, PreferencesActivity::class.java)
+ .setAction("info.nightscout.androidaps.MainActivity")
+ .putExtra("id", plugin.preferencesId)
+ )
+ })
+ true
+ }
+ /*
+ R.id.nav_survey -> {
+ startActivity(Intent(this, SurveyActivity::class.java))
+ return true
+ }
+ */
+ R.id.nav_defaultprofile -> {
+ startActivity(Intent(this@MainActivity, ProfileHelperActivity::class.java).setAction("info.nightscout.androidaps.MainActivity"))
+ true
+ }
+
+ R.id.nav_stats -> {
+ startActivity(Intent(this@MainActivity, StatsActivity::class.java).setAction("info.nightscout.androidaps.MainActivity"))
+ true
+ }
+
+ else ->
+ actionBarDrawerToggle.onOptionsItemSelected(menuItem)
+ }
+ })
// Setup views on 2nd and next activity start
// On 1st start app is still initializing, start() is delayed and run from EventAppInitialized
if (config.appInitialized) start()
@@ -332,115 +442,6 @@ class MainActivity : DaggerAppCompatActivityWithResult() {
super.onPanelClosed(featureId, menu)
}
- override fun onCreateOptionsMenu(menu: Menu): Boolean {
- super.onCreateOptionsMenu(menu)
- MenuCompat.setGroupDividerEnabled(menu, true)
- this.menu = menu
- menuInflater.inflate(R.menu.menu_main, menu)
- pluginPreferencesMenuItem = menu.findItem(R.id.nav_plugin_preferences)
- return true
- }
-
- override fun onOptionsItemSelected(item: MenuItem): Boolean {
- super.onOptionsItemSelected(item)
- when (item.itemId) {
- R.id.nav_preferences -> {
- protectionCheck.queryProtection(this, ProtectionCheck.Protection.PREFERENCES, {
- startActivity(
- Intent(this, PreferencesActivity::class.java)
- .setAction("info.nightscout.androidaps.MainActivity")
- .putExtra("id", -1)
- )
- })
- return true
- }
-
- R.id.nav_historybrowser -> {
- startActivity(Intent(this, HistoryBrowseActivity::class.java).setAction("info.nightscout.androidaps.MainActivity"))
- return true
- }
-
- R.id.nav_treatments -> {
- startActivity(Intent(this, TreatmentsActivity::class.java).setAction("info.nightscout.androidaps.MainActivity"))
- return true
- }
-
- R.id.nav_setupwizard -> {
- protectionCheck.queryProtection(this, ProtectionCheck.Protection.PREFERENCES, {
- startActivity(Intent(this, SetupWizardActivity::class.java).setAction("info.nightscout.androidaps.MainActivity"))
- })
- return true
- }
-
- R.id.nav_about -> {
- var message = "Build: ${BuildConfig.BUILDVERSION}\n"
- message += "Flavor: ${BuildConfig.FLAVOR}${BuildConfig.BUILD_TYPE}\n"
- message += "${rh.gs(info.nightscout.configuration.R.string.configbuilder_nightscoutversion_label)} ${activePlugin.activeNsClient?.detectedNsVersion() ?: rh.gs(info.nightscout.plugins.R.string.not_available_full)}"
- if (config.isEngineeringMode()) message += "\n${rh.gs(info.nightscout.configuration.R.string.engineering_mode_enabled)}"
- if (config.isUnfinishedMode()) message += "\nUnfinished mode enabled"
- if (!fabricPrivacy.fabricEnabled()) message += "\n${rh.gs(info.nightscout.core.ui.R.string.fabric_upload_disabled)}"
- message += rh.gs(info.nightscout.core.ui.R.string.about_link_urls)
- val messageSpanned = SpannableString(message)
- Linkify.addLinks(messageSpanned, Linkify.WEB_URLS)
- MaterialAlertDialogBuilder(this, info.nightscout.core.ui.R.style.DialogTheme)
- .setTitle(rh.gs(R.string.app_name) + " " + BuildConfig.VERSION)
- .setIcon(iconsProvider.getIcon())
- .setMessage(messageSpanned)
- .setPositiveButton(rh.gs(info.nightscout.core.ui.R.string.ok), null)
- .setNeutralButton(rh.gs(info.nightscout.core.ui.R.string.cta_dont_kill_my_app_info)) { _, _ ->
- startActivity(
- Intent(
- Intent.ACTION_VIEW,
- Uri.parse("https://dontkillmyapp.com/" + Build.MANUFACTURER.lowercase().replace(" ", "-"))
- )
- )
- }
- .create().apply {
- show()
- findViewById(android.R.id.message)?.movementMethod = LinkMovementMethod.getInstance()
- }
- return true
- }
-
- R.id.nav_exit -> {
- aapsLogger.debug(LTag.CORE, "Exiting")
- uel.log(Action.EXIT_AAPS, Sources.Aaps)
- rxBus.send(EventAppExit())
- finish()
- System.runFinalization()
- exitProcess(0)
- }
-
- R.id.nav_plugin_preferences -> {
- val plugin = (binding.mainPager.adapter as TabPageAdapter).getPluginAt(binding.mainPager.currentItem)
- protectionCheck.queryProtection(this, ProtectionCheck.Protection.PREFERENCES, {
- startActivity(
- Intent(this, PreferencesActivity::class.java)
- .setAction("info.nightscout.androidaps.MainActivity")
- .putExtra("id", plugin.preferencesId)
- )
- })
- return true
- }
- /*
- R.id.nav_survey -> {
- startActivity(Intent(this, SurveyActivity::class.java))
- return true
- }
- */
- R.id.nav_defaultprofile -> {
- startActivity(Intent(this, ProfileHelperActivity::class.java).setAction("info.nightscout.androidaps.MainActivity"))
- return true
- }
-
- R.id.nav_stats -> {
- startActivity(Intent(this, StatsActivity::class.java).setAction("info.nightscout.androidaps.MainActivity"))
- return true
- }
- }
- return actionBarDrawerToggle.onOptionsItemSelected(item)
- }
-
// Correct place for calling setUserStats() would be probably MainApp
// but we need to have it called at least once a day. Thus this location
diff --git a/app/src/main/java/info/nightscout/androidaps/activities/HistoryBrowseActivity.kt b/app/src/main/java/info/nightscout/androidaps/activities/HistoryBrowseActivity.kt
index 2ec0a57028..3859e79af0 100644
--- a/app/src/main/java/info/nightscout/androidaps/activities/HistoryBrowseActivity.kt
+++ b/app/src/main/java/info/nightscout/androidaps/activities/HistoryBrowseActivity.kt
@@ -4,14 +4,10 @@ import android.annotation.SuppressLint
import android.content.Context
import android.os.Bundle
import android.util.DisplayMetrics
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
import android.view.ViewGroup
import android.widget.LinearLayout
import android.widget.RelativeLayout
import android.widget.TextView
-import androidx.core.view.MenuProvider
import com.google.android.material.datepicker.MaterialDatePicker
import com.jjoe64.graphview.GraphView
import dagger.android.HasAndroidInjector
@@ -148,20 +144,6 @@ class HistoryBrowseActivity : TranslatedDaggerAppCompatActivity() {
historyBrowserData.overviewData.fromTime = bundle.getLong("start", 0)
historyBrowserData.overviewData.toTime = bundle.getLong("end", 0)
}
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
override fun onPause() {
diff --git a/core/ui/src/main/java/info/nightscout/core/ui/activities/TranslatedDaggerAppCompatActivity.kt b/core/ui/src/main/java/info/nightscout/core/ui/activities/TranslatedDaggerAppCompatActivity.kt
index 75884c5a6f..33442bba6c 100644
--- a/core/ui/src/main/java/info/nightscout/core/ui/activities/TranslatedDaggerAppCompatActivity.kt
+++ b/core/ui/src/main/java/info/nightscout/core/ui/activities/TranslatedDaggerAppCompatActivity.kt
@@ -1,6 +1,11 @@
package info.nightscout.core.ui.activities
import android.content.Context
+import android.os.Bundle
+import android.view.Menu
+import android.view.MenuInflater
+import android.view.MenuItem
+import androidx.core.view.MenuProvider
import dagger.android.support.DaggerAppCompatActivity
import info.nightscout.core.ui.locale.LocaleHelper
@@ -8,4 +13,23 @@ open class TranslatedDaggerAppCompatActivity : DaggerAppCompatActivity() {
override fun attachBaseContext(newBase: Context) {
super.attachBaseContext(LocaleHelper.wrap(newBase))
}
+
+ override fun onCreate(savedInstanceState: Bundle?) {
+ super.onCreate(savedInstanceState)
+
+ // Add menu items without overriding methods in the Activity
+ addMenuProvider(object : MenuProvider {
+ override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
+
+ override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
+ when (menuItem.itemId) {
+ android.R.id.home -> {
+ onBackPressedDispatcher.onBackPressed()
+ true
+ }
+
+ else -> false
+ }
+ })
+ }
}
diff --git a/plugins/configuration/src/main/java/info/nightscout/configuration/maintenance/activities/CustomWatchfaceImportListActivity.kt b/plugins/configuration/src/main/java/info/nightscout/configuration/maintenance/activities/CustomWatchfaceImportListActivity.kt
index f6f1c69caf..fdfc570fe9 100644
--- a/plugins/configuration/src/main/java/info/nightscout/configuration/maintenance/activities/CustomWatchfaceImportListActivity.kt
+++ b/plugins/configuration/src/main/java/info/nightscout/configuration/maintenance/activities/CustomWatchfaceImportListActivity.kt
@@ -3,17 +3,15 @@ package info.nightscout.configuration.maintenance.activities
import android.content.Intent
import android.os.Bundle
import android.view.LayoutInflater
-import android.view.MenuItem
import android.view.ViewGroup
-
import androidx.fragment.app.FragmentActivity
import androidx.recyclerview.widget.LinearLayoutManager
import androidx.recyclerview.widget.RecyclerView
+import info.nightscout.configuration.R
+import info.nightscout.configuration.databinding.CustomWatchfaceImportListActivityBinding
+import info.nightscout.configuration.databinding.CustomWatchfaceImportListItemBinding
import info.nightscout.core.ui.activities.TranslatedDaggerAppCompatActivity
import info.nightscout.interfaces.maintenance.PrefFileListProvider
-import info.nightscout.configuration.databinding.CustomWatchfaceImportListActivityBinding
-import info.nightscout.configuration.R
-import info.nightscout.configuration.databinding.CustomWatchfaceImportListItemBinding
import info.nightscout.interfaces.versionChecker.VersionCheckerUtils
import info.nightscout.rx.bus.RxBus
import info.nightscout.rx.events.EventMobileDataToWear
@@ -21,7 +19,12 @@ import info.nightscout.rx.logging.AAPSLogger
import info.nightscout.rx.weardata.CUSTOM_VERSION
import info.nightscout.rx.weardata.CwfData
import info.nightscout.rx.weardata.CwfDrawableFileMap
-import info.nightscout.rx.weardata.CwfMetadataKey.*
+import info.nightscout.rx.weardata.CwfMetadataKey.CWF_AUTHOR
+import info.nightscout.rx.weardata.CwfMetadataKey.CWF_AUTHOR_VERSION
+import info.nightscout.rx.weardata.CwfMetadataKey.CWF_CREATED_AT
+import info.nightscout.rx.weardata.CwfMetadataKey.CWF_FILENAME
+import info.nightscout.rx.weardata.CwfMetadataKey.CWF_NAME
+import info.nightscout.rx.weardata.CwfMetadataKey.CWF_VERSION
import info.nightscout.rx.weardata.CwfMetadataMap
import info.nightscout.rx.weardata.EventData
import info.nightscout.shared.extensions.toVisibility
@@ -109,14 +112,6 @@ class CustomWatchfaceImportListActivity: TranslatedDaggerAppCompatActivity() {
}
}
- override fun onOptionsItemSelected(item: MenuItem): Boolean {
- if (item.itemId == android.R.id.home) {
- finish()
- return true
- }
- return super.onOptionsItemSelected(item)
- }
-
private fun checkCustomVersion(metadata: CwfMetadataMap): Boolean {
metadata[CWF_VERSION]?.let { version ->
val currentAppVer = versionCheckerUtils.versionDigits(CUSTOM_VERSION)
diff --git a/plugins/configuration/src/main/java/info/nightscout/configuration/maintenance/activities/LogSettingActivity.kt b/plugins/configuration/src/main/java/info/nightscout/configuration/maintenance/activities/LogSettingActivity.kt
index 553bb319cb..ce966c7fc3 100644
--- a/plugins/configuration/src/main/java/info/nightscout/configuration/maintenance/activities/LogSettingActivity.kt
+++ b/plugins/configuration/src/main/java/info/nightscout/configuration/maintenance/activities/LogSettingActivity.kt
@@ -1,14 +1,10 @@
package info.nightscout.configuration.maintenance.activities
import android.os.Bundle
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
import android.view.View
import android.widget.CheckBox
import android.widget.LinearLayout
import android.widget.TextView
-import androidx.core.view.MenuProvider
import info.nightscout.configuration.R
import info.nightscout.configuration.databinding.ActivityLogsettingBinding
import info.nightscout.core.ui.activities.TranslatedDaggerAppCompatActivity
@@ -39,20 +35,6 @@ class LogSettingActivity : TranslatedDaggerAppCompatActivity() {
l.resetToDefaults()
createViewsForSettings()
}
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
private fun createViewsForSettings() {
diff --git a/plugins/configuration/src/main/java/info/nightscout/configuration/maintenance/activities/PrefImportListActivity.kt b/plugins/configuration/src/main/java/info/nightscout/configuration/maintenance/activities/PrefImportListActivity.kt
index acee12e375..8af1fd129d 100644
--- a/plugins/configuration/src/main/java/info/nightscout/configuration/maintenance/activities/PrefImportListActivity.kt
+++ b/plugins/configuration/src/main/java/info/nightscout/configuration/maintenance/activities/PrefImportListActivity.kt
@@ -3,12 +3,8 @@ package info.nightscout.configuration.maintenance.activities
import android.content.Intent
import android.os.Bundle
import android.view.LayoutInflater
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
import android.view.View
import android.view.ViewGroup
-import androidx.core.view.MenuProvider
import androidx.fragment.app.FragmentActivity
import androidx.recyclerview.widget.LinearLayoutManager
import androidx.recyclerview.widget.RecyclerView
@@ -44,21 +40,6 @@ class PrefImportListActivity : TranslatedDaggerAppCompatActivity() {
binding.recyclerview.layoutManager = LinearLayoutManager(this)
binding.recyclerview.adapter = RecyclerViewAdapter(prefFileListProvider.listPreferenceFiles(loadMetadata = true))
-
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
inner class RecyclerViewAdapter internal constructor(private var prefFileList: List) : RecyclerView.Adapter() {
diff --git a/plugins/main/src/main/java/info/nightscout/plugins/general/smsCommunicator/activities/SmsCommunicatorOtpActivity.kt b/plugins/main/src/main/java/info/nightscout/plugins/general/smsCommunicator/activities/SmsCommunicatorOtpActivity.kt
index d42f2c3e7a..6de730b20c 100644
--- a/plugins/main/src/main/java/info/nightscout/plugins/general/smsCommunicator/activities/SmsCommunicatorOtpActivity.kt
+++ b/plugins/main/src/main/java/info/nightscout/plugins/general/smsCommunicator/activities/SmsCommunicatorOtpActivity.kt
@@ -8,12 +8,8 @@ import android.graphics.Color
import android.os.Bundle
import android.text.Editable
import android.text.TextWatcher
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
import android.view.View
import android.view.WindowManager
-import androidx.core.view.MenuProvider
import com.google.common.primitives.Ints.min
import com.google.zxing.qrcode.decoder.ErrorCorrectionLevel
import info.nightscout.core.ui.activities.TranslatedDaggerAppCompatActivity
@@ -107,20 +103,6 @@ class SmsCommunicatorOtpActivity : TranslatedDaggerAppCompatActivity() {
true
}
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
@Synchronized
diff --git a/plugins/main/src/main/java/info/nightscout/plugins/general/wear/activities/CwfInfosActivity.kt b/plugins/main/src/main/java/info/nightscout/plugins/general/wear/activities/CwfInfosActivity.kt
index c457d69bfa..acdbf0f0b4 100644
--- a/plugins/main/src/main/java/info/nightscout/plugins/general/wear/activities/CwfInfosActivity.kt
+++ b/plugins/main/src/main/java/info/nightscout/plugins/general/wear/activities/CwfInfosActivity.kt
@@ -2,12 +2,8 @@ package info.nightscout.plugins.general.wear.activities
import android.os.Bundle
import android.view.LayoutInflater
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
import android.view.View
import android.view.ViewGroup
-import androidx.core.view.MenuProvider
import androidx.recyclerview.widget.LinearLayoutManager
import androidx.recyclerview.widget.RecyclerView
import info.nightscout.core.ui.activities.TranslatedDaggerAppCompatActivity
@@ -60,21 +56,6 @@ class CwfInfosActivity : TranslatedDaggerAppCompatActivity() {
supportActionBar?.setDisplayShowTitleEnabled(true)
updateGui()
-
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
override fun onPause() {
diff --git a/plugins/sync/src/main/java/info/nightscout/plugins/sync/openhumans/ui/OHLoginActivity.kt b/plugins/sync/src/main/java/info/nightscout/plugins/sync/openhumans/ui/OHLoginActivity.kt
index b7df7d81d8..bc770012c4 100644
--- a/plugins/sync/src/main/java/info/nightscout/plugins/sync/openhumans/ui/OHLoginActivity.kt
+++ b/plugins/sync/src/main/java/info/nightscout/plugins/sync/openhumans/ui/OHLoginActivity.kt
@@ -3,15 +3,11 @@ package info.nightscout.plugins.sync.openhumans.ui
import android.content.Intent
import android.net.Uri
import android.os.Bundle
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
import android.view.View
import android.widget.CheckBox
import androidx.activity.OnBackPressedCallback
import androidx.activity.viewModels
import androidx.browser.customtabs.CustomTabsIntent
-import androidx.core.view.MenuProvider
import androidx.core.view.ViewCompat
import androidx.core.view.WindowCompat
import androidx.core.view.WindowInsetsCompat
@@ -98,20 +94,6 @@ class OHLoginActivity : TranslatedDaggerAppCompatActivity() {
if (code != null) {
viewModel.submitBearerToken(code)
}
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
onBackPressedDispatcher.addCallback(this, object: OnBackPressedCallback(true) {
override fun handleOnBackPressed() {
if (!viewModel.goBack()) finish()
diff --git a/pump/combov2/src/main/kotlin/info/nightscout/pump/combov2/activities/ComboV2PairingActivity.kt b/pump/combov2/src/main/kotlin/info/nightscout/pump/combov2/activities/ComboV2PairingActivity.kt
index 6add815fd0..d895426c63 100644
--- a/pump/combov2/src/main/kotlin/info/nightscout/pump/combov2/activities/ComboV2PairingActivity.kt
+++ b/pump/combov2/src/main/kotlin/info/nightscout/pump/combov2/activities/ComboV2PairingActivity.kt
@@ -7,16 +7,12 @@ import android.os.Build
import android.os.Bundle
import android.text.Editable
import android.text.TextWatcher
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
import android.view.View
import androidx.activity.ComponentActivity
import androidx.activity.OnBackPressedCallback
import androidx.activity.result.ActivityResultLauncher
import androidx.activity.result.contract.ActivityResultContracts
import androidx.core.content.ContextCompat
-import androidx.core.view.MenuProvider
import androidx.databinding.DataBindingUtil
import androidx.lifecycle.Lifecycle
import androidx.lifecycle.lifecycleScope
@@ -202,20 +198,6 @@ class ComboV2PairingActivity : TranslatedDaggerAppCompatActivity() {
finish()
}
})
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
override fun onDestroy() {
diff --git a/pump/dana/src/main/java/info/nightscout/pump/dana/activities/DanaHistoryActivity.kt b/pump/dana/src/main/java/info/nightscout/pump/dana/activities/DanaHistoryActivity.kt
index d0d0edc9cb..aa67998f34 100644
--- a/pump/dana/src/main/java/info/nightscout/pump/dana/activities/DanaHistoryActivity.kt
+++ b/pump/dana/src/main/java/info/nightscout/pump/dana/activities/DanaHistoryActivity.kt
@@ -2,14 +2,10 @@ package info.nightscout.pump.dana.activities
import android.os.Bundle
import android.view.LayoutInflater
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
import android.view.View
import android.view.ViewGroup
import android.widget.AdapterView
import android.widget.ArrayAdapter
-import androidx.core.view.MenuProvider
import androidx.recyclerview.widget.LinearLayoutManager
import androidx.recyclerview.widget.RecyclerView
import info.nightscout.core.ui.activities.TranslatedDaggerAppCompatActivity
@@ -141,20 +137,6 @@ class DanaHistoryActivity : TranslatedDaggerAppCompatActivity() {
showingType = selected.type
swapAdapter(selected.type)
}
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
inner class RecyclerViewAdapter internal constructor(private var historyList: List) : RecyclerView.Adapter() {
diff --git a/pump/dana/src/main/java/info/nightscout/pump/dana/activities/DanaUserOptionsActivity.kt b/pump/dana/src/main/java/info/nightscout/pump/dana/activities/DanaUserOptionsActivity.kt
index 941a536cf3..b410272c48 100644
--- a/pump/dana/src/main/java/info/nightscout/pump/dana/activities/DanaUserOptionsActivity.kt
+++ b/pump/dana/src/main/java/info/nightscout/pump/dana/activities/DanaUserOptionsActivity.kt
@@ -2,10 +2,6 @@ package info.nightscout.pump.dana.activities
import android.content.Context
import android.os.Bundle
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
-import androidx.core.view.MenuProvider
import info.nightscout.core.ui.activities.TranslatedDaggerAppCompatActivity
import info.nightscout.core.utils.fabric.FabricPrivacy
import info.nightscout.interfaces.Constants
@@ -122,21 +118,6 @@ class DanaUserOptionsActivity : TranslatedDaggerAppCompatActivity() {
aapsLogger.error(LTag.PUMP, "No settings loaded from pump!")
else
setData()
-
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
private fun setData() {
diff --git a/pump/danars/src/main/java/info/nightscout/pump/danars/activities/BLEScanActivity.kt b/pump/danars/src/main/java/info/nightscout/pump/danars/activities/BLEScanActivity.kt
index 47a0616985..b3a1a9a1ee 100644
--- a/pump/danars/src/main/java/info/nightscout/pump/danars/activities/BLEScanActivity.kt
+++ b/pump/danars/src/main/java/info/nightscout/pump/danars/activities/BLEScanActivity.kt
@@ -15,15 +15,11 @@ import android.os.Build
import android.os.Bundle
import android.os.Handler
import android.os.Looper
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
import android.view.View
import android.view.ViewGroup
import android.widget.BaseAdapter
import android.widget.TextView
import androidx.core.app.ActivityCompat
-import androidx.core.view.MenuProvider
import info.nightscout.core.ui.activities.TranslatedDaggerAppCompatActivity
import info.nightscout.core.ui.toast.ToastUtils
import info.nightscout.core.utils.extensions.safeEnable
@@ -69,21 +65,6 @@ class BLEScanActivity : TranslatedDaggerAppCompatActivity() {
binding.bleScannerListview.emptyView = binding.bleScannerNoDevice
binding.bleScannerListview.adapter = listAdapter
listAdapter?.notifyDataSetChanged()
-
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
override fun onResume() {
diff --git a/pump/diaconn/src/main/java/info/nightscout/pump/diaconn/activities/DiaconnG8BLEScanActivity.kt b/pump/diaconn/src/main/java/info/nightscout/pump/diaconn/activities/DiaconnG8BLEScanActivity.kt
index f3f3a65eae..ef46a1f1a7 100644
--- a/pump/diaconn/src/main/java/info/nightscout/pump/diaconn/activities/DiaconnG8BLEScanActivity.kt
+++ b/pump/diaconn/src/main/java/info/nightscout/pump/diaconn/activities/DiaconnG8BLEScanActivity.kt
@@ -18,15 +18,11 @@ import android.os.Bundle
import android.os.Handler
import android.os.Looper
import android.os.ParcelUuid
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
import android.view.View
import android.view.ViewGroup
import android.widget.BaseAdapter
import android.widget.TextView
import androidx.core.app.ActivityCompat
-import androidx.core.view.MenuProvider
import info.nightscout.core.ui.activities.TranslatedDaggerAppCompatActivity
import info.nightscout.core.ui.toast.ToastUtils
import info.nightscout.core.utils.extensions.safeEnable
@@ -71,21 +67,6 @@ class DiaconnG8BLEScanActivity : TranslatedDaggerAppCompatActivity() {
binding.bleScannerListview.emptyView = binding.bleScannerNoDevice
binding.bleScannerListview.adapter = listAdapter
listAdapter?.notifyDataSetChanged()
-
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
override fun onResume() {
diff --git a/pump/diaconn/src/main/java/info/nightscout/pump/diaconn/activities/DiaconnG8HistoryActivity.kt b/pump/diaconn/src/main/java/info/nightscout/pump/diaconn/activities/DiaconnG8HistoryActivity.kt
index d07f23adc0..baeb1ab5e2 100644
--- a/pump/diaconn/src/main/java/info/nightscout/pump/diaconn/activities/DiaconnG8HistoryActivity.kt
+++ b/pump/diaconn/src/main/java/info/nightscout/pump/diaconn/activities/DiaconnG8HistoryActivity.kt
@@ -2,15 +2,11 @@ package info.nightscout.pump.diaconn.activities
import android.os.Bundle
import android.view.LayoutInflater
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
import android.view.View
import android.view.ViewGroup
import android.widget.AdapterView
import android.widget.ArrayAdapter
import android.widget.TextView
-import androidx.core.view.MenuProvider
import androidx.recyclerview.widget.LinearLayoutManager
import androidx.recyclerview.widget.RecyclerView
import info.nightscout.core.ui.activities.TranslatedDaggerAppCompatActivity
@@ -120,20 +116,6 @@ class DiaconnG8HistoryActivity : TranslatedDaggerAppCompatActivity() {
showingType = selected.type
swapAdapter(selected.type)
}
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
inner class RecyclerViewAdapter internal constructor(private var historyList: List) : RecyclerView.Adapter() {
diff --git a/pump/diaconn/src/main/java/info/nightscout/pump/diaconn/activities/DiaconnG8UserOptionsActivity.kt b/pump/diaconn/src/main/java/info/nightscout/pump/diaconn/activities/DiaconnG8UserOptionsActivity.kt
index 7566ca7a91..708bdedcca 100644
--- a/pump/diaconn/src/main/java/info/nightscout/pump/diaconn/activities/DiaconnG8UserOptionsActivity.kt
+++ b/pump/diaconn/src/main/java/info/nightscout/pump/diaconn/activities/DiaconnG8UserOptionsActivity.kt
@@ -2,13 +2,9 @@ package info.nightscout.pump.diaconn.activities
import android.content.Context
import android.os.Bundle
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
import android.view.View
import android.widget.AdapterView
import android.widget.ArrayAdapter
-import androidx.core.view.MenuProvider
import info.nightscout.core.ui.activities.TranslatedDaggerAppCompatActivity
import info.nightscout.core.ui.toast.ToastUtils
import info.nightscout.core.utils.fabric.FabricPrivacy
@@ -107,20 +103,6 @@ class DiaconnG8UserOptionsActivity : TranslatedDaggerAppCompatActivity() {
2 -> binding.pumplangKorean.isChecked = true
3 -> binding.pumplangEnglish.isChecked = true
}
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
private fun onSaveAlarmClick() {
diff --git a/pump/eopatch/src/main/java/info/nightscout/androidaps/plugins/pump/eopatch/ui/EopatchActivity.kt b/pump/eopatch/src/main/java/info/nightscout/androidaps/plugins/pump/eopatch/ui/EopatchActivity.kt
index d6f1625645..f85e64a223 100644
--- a/pump/eopatch/src/main/java/info/nightscout/androidaps/plugins/pump/eopatch/ui/EopatchActivity.kt
+++ b/pump/eopatch/src/main/java/info/nightscout/androidaps/plugins/pump/eopatch/ui/EopatchActivity.kt
@@ -5,13 +5,9 @@ import android.content.Context
import android.content.Intent
import android.content.pm.ActivityInfo
import android.os.Bundle
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
import android.view.MotionEvent
import androidx.activity.OnBackPressedCallback
import androidx.appcompat.app.AlertDialog
-import androidx.core.view.MenuProvider
import androidx.lifecycle.ViewModelProvider
import info.nightscout.androidaps.plugins.pump.eopatch.R
import info.nightscout.androidaps.plugins.pump.eopatch.code.EventType
@@ -123,20 +119,6 @@ class EopatchActivity : EoBaseActivity() {
}
}
})
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
override fun onNewIntent(intent: Intent?) {
diff --git a/pump/medtrum/src/main/java/info/nightscout/pump/medtrum/ui/MedtrumActivity.kt b/pump/medtrum/src/main/java/info/nightscout/pump/medtrum/ui/MedtrumActivity.kt
index 24ef32e2f1..455e168a3e 100644
--- a/pump/medtrum/src/main/java/info/nightscout/pump/medtrum/ui/MedtrumActivity.kt
+++ b/pump/medtrum/src/main/java/info/nightscout/pump/medtrum/ui/MedtrumActivity.kt
@@ -4,13 +4,8 @@ import android.content.Context
import android.content.Intent
import android.content.pm.ActivityInfo
import android.os.Bundle
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
-import android.view.MotionEvent
import android.view.WindowManager
import androidx.activity.OnBackPressedCallback
-import androidx.core.view.MenuProvider
import androidx.lifecycle.ViewModelProvider
import info.nightscout.core.utils.extensions.safeGetSerializableExtra
import info.nightscout.pump.medtrum.R
@@ -97,20 +92,6 @@ class MedtrumActivity : MedtrumBaseActivity() {
}
}
})
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
override fun onNewIntent(intent: Intent?) {
diff --git a/pump/medtrum/src/main/java/info/nightscout/pump/medtrum/ui/MedtrumBaseActivity.kt b/pump/medtrum/src/main/java/info/nightscout/pump/medtrum/ui/MedtrumBaseActivity.kt
index edbaee2073..c4c1dda02c 100644
--- a/pump/medtrum/src/main/java/info/nightscout/pump/medtrum/ui/MedtrumBaseActivity.kt
+++ b/pump/medtrum/src/main/java/info/nightscout/pump/medtrum/ui/MedtrumBaseActivity.kt
@@ -7,14 +7,13 @@ import androidx.annotation.LayoutRes
import androidx.databinding.DataBindingUtil
import androidx.databinding.ViewDataBinding
import androidx.lifecycle.ViewModelProvider
-import dagger.android.support.DaggerAppCompatActivity
-import info.nightscout.core.ui.R
+import info.nightscout.core.ui.activities.TranslatedDaggerAppCompatActivity
import info.nightscout.pump.medtrum.di.MedtrumPluginQualifier
import info.nightscout.rx.AapsSchedulers
import io.reactivex.rxjava3.disposables.CompositeDisposable
import javax.inject.Inject
-abstract class MedtrumBaseActivity : DaggerAppCompatActivity(), MedtrumBaseNavigator {
+abstract class MedtrumBaseActivity : TranslatedDaggerAppCompatActivity(), MedtrumBaseNavigator {
@Inject
@MedtrumPluginQualifier
lateinit var viewModelFactory: ViewModelProvider.Factory
diff --git a/pump/omnipod-common/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/common/ui/wizard/common/activity/OmnipodWizardActivityBase.kt b/pump/omnipod-common/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/common/ui/wizard/common/activity/OmnipodWizardActivityBase.kt
index 0a2b90971e..6b8caea079 100644
--- a/pump/omnipod-common/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/common/ui/wizard/common/activity/OmnipodWizardActivityBase.kt
+++ b/pump/omnipod-common/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/common/ui/wizard/common/activity/OmnipodWizardActivityBase.kt
@@ -1,12 +1,8 @@
package info.nightscout.androidaps.plugins.pump.omnipod.common.ui.wizard.common.activity
import android.os.Bundle
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
import androidx.activity.OnBackPressedCallback
import androidx.appcompat.app.AlertDialog
-import androidx.core.view.MenuProvider
import androidx.navigation.NavController
import androidx.navigation.fragment.NavHostFragment
import info.nightscout.androidaps.plugins.pump.omnipod.common.R
@@ -21,20 +17,6 @@ abstract class OmnipodWizardActivityBase : TranslatedDaggerAppCompatActivity() {
exitActivityAfterConfirmation()
}
})
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
fun exitActivityAfterConfirmation() {
diff --git a/pump/omnipod-dash/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/dash/ui/DashPodHistoryActivity.kt b/pump/omnipod-dash/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/dash/ui/DashPodHistoryActivity.kt
index e88f1f1209..67568e4cf6 100644
--- a/pump/omnipod-dash/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/dash/ui/DashPodHistoryActivity.kt
+++ b/pump/omnipod-dash/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/dash/ui/DashPodHistoryActivity.kt
@@ -3,16 +3,12 @@ package info.nightscout.androidaps.plugins.pump.omnipod.dash.ui
import android.os.Bundle
import android.os.SystemClock
import android.view.LayoutInflater
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
import android.view.View
import android.view.ViewGroup
import android.widget.AdapterView
import android.widget.ArrayAdapter
import android.widget.Spinner
import android.widget.TextView
-import androidx.core.view.MenuProvider
import androidx.recyclerview.widget.LinearLayoutManager
import androidx.recyclerview.widget.RecyclerView
import info.nightscout.androidaps.plugins.pump.omnipod.common.definition.OmnipodCommandType
@@ -187,21 +183,6 @@ class DashPodHistoryActivity : TranslatedDaggerAppCompatActivity() {
}
}
}
-
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
private fun getTypeList(list: List): List {
diff --git a/pump/omnipod-dash/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/dash/ui/DashPodManagementActivity.kt b/pump/omnipod-dash/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/dash/ui/DashPodManagementActivity.kt
index 42786892c5..2c205c502f 100644
--- a/pump/omnipod-dash/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/dash/ui/DashPodManagementActivity.kt
+++ b/pump/omnipod-dash/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/dash/ui/DashPodManagementActivity.kt
@@ -3,10 +3,6 @@ package info.nightscout.androidaps.plugins.pump.omnipod.dash.ui
import android.content.Context
import android.content.Intent
import android.os.Bundle
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
-import androidx.core.view.MenuProvider
import dagger.android.HasAndroidInjector
import info.nightscout.androidaps.plugins.pump.omnipod.common.queue.command.CommandPlayTestBeep
import info.nightscout.androidaps.plugins.pump.omnipod.common.ui.wizard.activation.PodActivationWizardActivity
@@ -110,20 +106,6 @@ class DashPodManagementActivity : TranslatedDaggerAppCompatActivity() {
binding.buttonPodHistory.setOnClickListener {
startActivity(Intent(this, DashPodHistoryActivity::class.java))
}
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
override fun onResume() {
diff --git a/pump/omnipod-eros/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/eros/ui/ErosPodHistoryActivity.kt b/pump/omnipod-eros/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/eros/ui/ErosPodHistoryActivity.kt
index 689c140929..3d57a5855a 100644
--- a/pump/omnipod-eros/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/eros/ui/ErosPodHistoryActivity.kt
+++ b/pump/omnipod-eros/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/eros/ui/ErosPodHistoryActivity.kt
@@ -4,24 +4,20 @@ import android.annotation.SuppressLint
import android.os.Bundle
import android.os.SystemClock
import android.view.LayoutInflater
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
import android.view.View
import android.view.ViewGroup
import android.widget.AdapterView
import android.widget.ArrayAdapter
import android.widget.Spinner
import android.widget.TextView
-import androidx.core.view.MenuProvider
import androidx.recyclerview.widget.LinearLayoutManager
import androidx.recyclerview.widget.RecyclerView
-import dagger.android.support.DaggerAppCompatActivity
import info.nightscout.androidaps.plugins.pump.omnipod.eros.R
import info.nightscout.androidaps.plugins.pump.omnipod.eros.definition.PodHistoryEntryType
import info.nightscout.androidaps.plugins.pump.omnipod.eros.history.ErosHistory
import info.nightscout.androidaps.plugins.pump.omnipod.eros.history.database.ErosHistoryRecordEntity
import info.nightscout.androidaps.plugins.pump.omnipod.eros.util.AapsOmnipodUtil
+import info.nightscout.core.ui.activities.TranslatedDaggerAppCompatActivity
import info.nightscout.interfaces.profile.Profile.ProfileValue
import info.nightscout.interfaces.pump.defs.PumpType
import info.nightscout.pump.common.defs.PumpHistoryEntryGroup
@@ -35,7 +31,7 @@ import java.util.Calendar
import java.util.GregorianCalendar
import javax.inject.Inject
-class ErosPodHistoryActivity : DaggerAppCompatActivity() {
+class ErosPodHistoryActivity : TranslatedDaggerAppCompatActivity() {
@Inject lateinit var aapsLogger: AAPSLogger
@Inject lateinit var aapsOmnipodUtil: AapsOmnipodUtil
@@ -127,21 +123,6 @@ class ErosPodHistoryActivity : DaggerAppCompatActivity() {
filterHistory(PumpHistoryEntryGroup.All)
}
}
-
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
private fun getTypeList(list: List): List {
diff --git a/pump/omnipod-eros/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/eros/ui/ErosPodManagementActivity.kt b/pump/omnipod-eros/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/eros/ui/ErosPodManagementActivity.kt
index 1792145c3d..8ec8aeaa40 100644
--- a/pump/omnipod-eros/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/eros/ui/ErosPodManagementActivity.kt
+++ b/pump/omnipod-eros/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/eros/ui/ErosPodManagementActivity.kt
@@ -5,10 +5,6 @@ import android.content.Intent
import android.os.Bundle
import android.os.Handler
import android.os.HandlerThread
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
-import androidx.core.view.MenuProvider
import dagger.android.HasAndroidInjector
import info.nightscout.androidaps.plugins.pump.common.events.EventRileyLinkDeviceStatusChange
import info.nightscout.androidaps.plugins.pump.common.hw.rileylink.dialog.RileyLinkStatusActivity
@@ -153,20 +149,6 @@ class ErosPodManagementActivity : TranslatedDaggerAppCompatActivity() {
binding.buttonPodHistory.setOnClickListener {
startActivity(Intent(this, ErosPodHistoryActivity::class.java))
}
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
override fun onResume() {
diff --git a/pump/pump-common/src/main/java/info/nightscout/pump/common/ui/PumpBLEConfigActivity.kt b/pump/pump-common/src/main/java/info/nightscout/pump/common/ui/PumpBLEConfigActivity.kt
index 42928f570f..4be0fe78e6 100644
--- a/pump/pump-common/src/main/java/info/nightscout/pump/common/ui/PumpBLEConfigActivity.kt
+++ b/pump/pump-common/src/main/java/info/nightscout/pump/common/ui/PumpBLEConfigActivity.kt
@@ -13,16 +13,12 @@ import android.content.Context
import android.os.Bundle
import android.os.Handler
import android.os.HandlerThread
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
import android.view.View
import android.view.ViewGroup
import android.widget.AdapterView
import android.widget.AdapterView.OnItemClickListener
import android.widget.BaseAdapter
import android.widget.TextView
-import androidx.core.view.MenuProvider
import info.nightscout.core.ui.activities.TranslatedDaggerAppCompatActivity
import info.nightscout.core.ui.dialogs.OKDialog
import info.nightscout.interfaces.plugin.ActivePlugin
@@ -143,21 +139,6 @@ class PumpBLEConfigActivity : TranslatedDaggerAppCompatActivity() {
updateCurrentlySelectedBTDevice()
})
}
-
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
private fun updateCurrentlySelectedBTDevice() {
diff --git a/pump/rileylink/src/main/java/info/nightscout/androidaps/plugins/pump/common/dialog/RileyLinkBLEConfigActivity.kt b/pump/rileylink/src/main/java/info/nightscout/androidaps/plugins/pump/common/dialog/RileyLinkBLEConfigActivity.kt
index da05125412..25967a61f5 100644
--- a/pump/rileylink/src/main/java/info/nightscout/androidaps/plugins/pump/common/dialog/RileyLinkBLEConfigActivity.kt
+++ b/pump/rileylink/src/main/java/info/nightscout/androidaps/plugins/pump/common/dialog/RileyLinkBLEConfigActivity.kt
@@ -17,9 +17,6 @@ import android.os.Bundle
import android.os.Handler
import android.os.HandlerThread
import android.os.ParcelUuid
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
import android.view.View
import android.view.ViewGroup
import android.widget.AdapterView
@@ -28,7 +25,6 @@ import android.widget.BaseAdapter
import android.widget.TextView
import android.widget.Toast
import androidx.core.app.ActivityCompat
-import androidx.core.view.MenuProvider
import info.nightscout.androidaps.plugins.pump.common.hw.rileylink.R
import info.nightscout.androidaps.plugins.pump.common.hw.rileylink.RileyLinkConst
import info.nightscout.androidaps.plugins.pump.common.hw.rileylink.RileyLinkUtil
@@ -121,21 +117,6 @@ class RileyLinkBLEConfigActivity : TranslatedDaggerAppCompatActivity() {
updateCurrentlySelectedRileyLink()
})
}
-
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
private fun updateCurrentlySelectedRileyLink() {
diff --git a/ui/src/main/java/info/nightscout/ui/activities/ProfileHelperActivity.kt b/ui/src/main/java/info/nightscout/ui/activities/ProfileHelperActivity.kt
index 841e48ff5c..98354f0a49 100644
--- a/ui/src/main/java/info/nightscout/ui/activities/ProfileHelperActivity.kt
+++ b/ui/src/main/java/info/nightscout/ui/activities/ProfileHelperActivity.kt
@@ -4,12 +4,8 @@ import android.annotation.SuppressLint
import android.os.Bundle
import android.text.Editable
import android.text.TextWatcher
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
import android.widget.ArrayAdapter
import android.widget.TextView
-import androidx.core.view.MenuProvider
import com.google.android.material.tabs.TabLayout
import com.google.common.collect.Lists
import info.nightscout.core.profile.ProfileSealed
@@ -254,21 +250,6 @@ class ProfileHelperActivity : TranslatedDaggerAppCompatActivity() {
binding.basalPctFromTddLabel.labelFor = binding.basalPctFromTdd.editTextId
switchTab(0, typeSelected[0], false)
-
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
private fun getProfile(age: Int, tdd: Double, weight: Double, basalPct: Double, tab: Int): PureProfile? =
diff --git a/ui/src/main/java/info/nightscout/ui/activities/QuickWizardListActivity.kt b/ui/src/main/java/info/nightscout/ui/activities/QuickWizardListActivity.kt
index ea69943ad6..0cda822fd9 100644
--- a/ui/src/main/java/info/nightscout/ui/activities/QuickWizardListActivity.kt
+++ b/ui/src/main/java/info/nightscout/ui/activities/QuickWizardListActivity.kt
@@ -5,11 +5,13 @@ import android.os.Bundle
import android.util.SparseArray
import android.view.LayoutInflater
import android.view.Menu
+import android.view.MenuInflater
import android.view.MenuItem
import android.view.MotionEvent
import android.view.View
import android.view.ViewGroup
import androidx.core.util.forEach
+import androidx.core.view.MenuProvider
import androidx.fragment.app.FragmentManager
import androidx.recyclerview.widget.ItemTouchHelper
import androidx.recyclerview.widget.LinearLayoutManager
@@ -152,6 +154,14 @@ class QuickWizardListActivity : TranslatedDaggerAppCompatActivity(), OnStartDrag
val editQuickWizardDialog = EditQuickWizardDialog()
editQuickWizardDialog.show(manager, "EditQuickWizardDialog")
}
+ addMenuProvider(object : MenuProvider {
+ override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {
+ menuInflater.inflate(info.nightscout.core.utils.R.menu.menu_actions, menu)
+ }
+
+ override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
+ actionHelper.onOptionsItemSelected(menuItem)
+ })
}
override fun onResume() {
@@ -181,22 +191,6 @@ class QuickWizardListActivity : TranslatedDaggerAppCompatActivity(), OnStartDrag
})
}
- override fun onCreateOptionsMenu(menu: Menu): Boolean {
- menuInflater.inflate(info.nightscout.core.utils.R.menu.menu_actions, menu)
- return super.onCreateOptionsMenu(menu)
- }
-
- override fun onOptionsItemSelected(item: MenuItem): Boolean =
- when (item.itemId) {
- android.R.id.home -> {
- finish()
- true
- }
-
- else -> actionHelper.onOptionsItemSelected(item)
-
- }
-
private fun getConfirmationText(selectedItems: SparseArray): String {
if (selectedItems.size() == 1) {
val entry = selectedItems.valueAt(0)
diff --git a/ui/src/main/java/info/nightscout/ui/activities/StatsActivity.kt b/ui/src/main/java/info/nightscout/ui/activities/StatsActivity.kt
index 197c6df3d1..5c710e4a27 100644
--- a/ui/src/main/java/info/nightscout/ui/activities/StatsActivity.kt
+++ b/ui/src/main/java/info/nightscout/ui/activities/StatsActivity.kt
@@ -4,11 +4,7 @@ import android.annotation.SuppressLint
import android.os.Bundle
import android.os.Handler
import android.os.HandlerThread
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
import android.widget.TextView
-import androidx.core.view.MenuProvider
import info.nightscout.core.ui.activities.TranslatedDaggerAppCompatActivity
import info.nightscout.core.ui.dialogs.OKDialog
import info.nightscout.core.utils.fabric.FabricPrivacy
@@ -104,20 +100,6 @@ class StatsActivity : TranslatedDaggerAppCompatActivity() {
}
}
}
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
override fun onPause() {
diff --git a/ui/src/main/java/info/nightscout/ui/activities/TDDStatsActivity.kt b/ui/src/main/java/info/nightscout/ui/activities/TDDStatsActivity.kt
index f890ce09aa..11558479bf 100644
--- a/ui/src/main/java/info/nightscout/ui/activities/TDDStatsActivity.kt
+++ b/ui/src/main/java/info/nightscout/ui/activities/TDDStatsActivity.kt
@@ -5,9 +5,6 @@ import android.graphics.Rect
import android.os.Bundle
import android.text.TextUtils
import android.view.KeyEvent
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
import android.view.MotionEvent
import android.view.View
import android.view.WindowManager
@@ -17,7 +14,6 @@ import android.widget.EditText
import android.widget.TableLayout
import android.widget.TableRow
import android.widget.TextView
-import androidx.core.view.MenuProvider
import info.nightscout.core.ui.activities.TranslatedDaggerAppCompatActivity
import info.nightscout.core.utils.fabric.FabricPrivacy
import info.nightscout.database.entities.TotalDailyDose
@@ -200,20 +196,6 @@ class TDDStatsActivity : TranslatedDaggerAppCompatActivity() {
}
}
loadDataFromDB()
- // Add menu items without overriding methods in the Activity
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
override fun onResume() {
diff --git a/ui/src/main/java/info/nightscout/ui/activities/TreatmentsActivity.kt b/ui/src/main/java/info/nightscout/ui/activities/TreatmentsActivity.kt
index ee79248e3f..093079f5e3 100644
--- a/ui/src/main/java/info/nightscout/ui/activities/TreatmentsActivity.kt
+++ b/ui/src/main/java/info/nightscout/ui/activities/TreatmentsActivity.kt
@@ -1,10 +1,6 @@
package info.nightscout.ui.activities
import android.os.Bundle
-import android.view.Menu
-import android.view.MenuInflater
-import android.view.MenuItem
-import androidx.core.view.MenuProvider
import androidx.fragment.app.Fragment
import androidx.fragment.app.FragmentTransaction
import com.google.android.material.tabs.TabLayout
@@ -64,20 +60,6 @@ class TreatmentsActivity : TranslatedDaggerAppCompatActivity() {
override fun onTabUnselected(tab: TabLayout.Tab) {}
override fun onTabReselected(tab: TabLayout.Tab) {}
})
-
- addMenuProvider(object : MenuProvider {
- override fun onCreateMenu(menu: Menu, menuInflater: MenuInflater) {}
-
- override fun onMenuItemSelected(menuItem: MenuItem): Boolean =
- when (menuItem.itemId) {
- android.R.id.home -> {
- onBackPressedDispatcher.onBackPressed()
- true
- }
-
- else -> false
- }
- })
}
private fun setFragment(selectedFragment: Fragment) {