From a07a4beaf8513125ace0921d19763310c1ea81e1 Mon Sep 17 00:00:00 2001 From: Johannes Mockenhaupt Date: Fri, 2 Feb 2018 11:50:00 +0100 Subject: [PATCH] Combo: update timestampOfLastKnownPumpBolusRecord after bolusing. --- .../androidaps/plugins/PumpCombo/ComboPlugin.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/info/nightscout/androidaps/plugins/PumpCombo/ComboPlugin.java b/app/src/main/java/info/nightscout/androidaps/plugins/PumpCombo/ComboPlugin.java index bd58ce56ef..dc8ea4ca57 100644 --- a/app/src/main/java/info/nightscout/androidaps/plugins/PumpCombo/ComboPlugin.java +++ b/app/src/main/java/info/nightscout/androidaps/plugins/PumpCombo/ComboPlugin.java @@ -565,7 +565,9 @@ public class ComboPlugin implements PluginBase, PumpInterface, ConstraintsInterf return new PumpEnactResult().success(false).enacted(true) .comment(MainApp.gs(R.string.combo_error_updating_treatment_record)); - // partial bolus was delivered + timestampOfLastKnownPumpBolusRecord = lastPumpBolus.timestamp; + + // only a partial bolus was delivered if (Math.abs(lastPumpBolus.amount - detailedBolusInfo.insulin) > 0.01) { if (cancelBolus) { return new PumpEnactResult().success(true).enacted(true); @@ -1119,8 +1121,6 @@ public class ComboPlugin implements PluginBase, PumpInterface, ConstraintsInterf return null; } - // TODO still regularly continues even though no changes on pump exist ... - // OPTIMIZE this reads the entire history on start, so this could be optimized by persisting // `timestampOfLastKnownPumpBolusRecord`, though this should be thought through, to make sure // all scenarios are covered