From 1f4f5600bc1f1963d8b73e4ee2ecb6590d371263 Mon Sep 17 00:00:00 2001
From: Milos Kozak <m.kozak@sysop.cz>
Date: Tue, 5 May 2020 23:27:01 +0200
Subject: [PATCH] NoSplashAppCompatActivity -> core

---
 app/build.gradle                                           | 2 --
 app/src/main/res/values/strings.xml                        | 1 -
 app/src/main/res/values/styles.xml                         | 6 ------
 build.gradle                                               | 2 ++
 core/build.gradle                                          | 5 ++++-
 .../androidaps/activities/NoSplashAppCompatActivity.kt     | 4 ++--
 .../nightscout/androidaps/utils/locale}/LocaleHelper.kt    | 2 +-
 core/src/main/res/values/layout.xml                        | 7 +++++++
 core/src/main/res/values/strings.xml                       | 2 ++
 9 files changed, 18 insertions(+), 13 deletions(-)
 rename {app => core}/src/main/java/info/nightscout/androidaps/activities/NoSplashAppCompatActivity.kt (89%)
 rename {app/src/main/java/info/nightscout/androidaps/utils => core/src/main/java/info/nightscout/androidaps/utils/locale}/LocaleHelper.kt (98%)

diff --git a/app/build.gradle b/app/build.gradle
index 593efb2304..fa13e0eea0 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -30,8 +30,6 @@ ext {
     dexmakerVersion = "1.2"
     retrofit2Version = '2.8.1'
     okhttp3Version = '4.6.0'
-    coroutinesVersion = '1.3.5'
-    activityVersion = '1.2.0-alpha03'
 }
 
 
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index c07ae20309..a3f9ff20a1 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -1108,7 +1108,6 @@
     <string name="nav_setupwizard">Setup Wizard</string>
     <string name="setupwizard_finish">FINISH</string>
     <string name="setupwizard_language_prompt">Select your language</string>
-    <string name="key_language" translatable="false">language</string>
     <string name="key_openapsama_min_5m_carbimpact" translatable="false">openapsama_min_5m_carbimpact</string>
     <string name="boluserrorcode">Asked: %1$.2fU Delivered: %2$.2fU Error code: %3$s</string>
     <string name="firstinsulinincrement">First insulin increment</string>
diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml
index 4914afa9fe..747db85115 100644
--- a/app/src/main/res/values/styles.xml
+++ b/app/src/main/res/values/styles.xml
@@ -16,12 +16,6 @@
         <item name="dialogTitleIconTint">@color/dialog_title_icon_tint</item>
     </style>
 
-    <style name="AppTheme.NoActionBar" parent="Theme.AppCompat.NoActionBar">
-        <item name="colorPrimary">@color/colorPrimary</item>
-        <item name="colorPrimaryDark">@color/colorPrimaryDark</item>
-        <item name="colorAccent">@color/colorAccent</item>
-    </style>
-
     <style name="Theme.AppCompat.Translucent" parent="Theme.AppCompat.NoActionBar">
         <item name="android:windowNoTitle">true</item>
         <item name="android:windowBackground">@android:color/transparent</item>
diff --git a/build.gradle b/build.gradle
index 9635afae0e..b340946773 100644
--- a/build.gradle
+++ b/build.gradle
@@ -10,6 +10,8 @@ buildscript {
         room_version = '2.2.5'
         lifecycle_version = '2.2.0'
         dagger_version = '2.27'
+        coroutinesVersion = '1.3.5'
+        activityVersion = '1.2.0-alpha04'
     }
     repositories {
         google()
diff --git a/core/build.gradle b/core/build.gradle
index 55829c53d1..e81f23f7b6 100644
--- a/core/build.gradle
+++ b/core/build.gradle
@@ -1,7 +1,7 @@
 apply plugin: 'com.android.library'
 apply plugin: 'kotlin-android'
-apply plugin: 'kotlin-kapt'
 apply plugin: 'kotlin-android-extensions'
+apply plugin: 'kotlin-kapt'
 
 android {
     compileSdkVersion 28
@@ -30,6 +30,7 @@ android {
         }
         firebaseDisable {
             System.setProperty("disableFirebase", "true")
+            ext.enableCrashlytics = false
         }
     }
     compileOptions {
@@ -43,6 +44,8 @@ dependencies {
     implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
     implementation 'androidx.appcompat:appcompat:1.1.0'
     implementation "androidx.preference:preference-ktx:1.1.1"
+    implementation "androidx.activity:activity:${activityVersion}"
+    implementation "androidx.activity:activity-ktx:${activityVersion}"
 
     implementation "com.google.dagger:dagger-android:$dagger_version"
     implementation "com.google.dagger:dagger-android-support:$dagger_version"
diff --git a/app/src/main/java/info/nightscout/androidaps/activities/NoSplashAppCompatActivity.kt b/core/src/main/java/info/nightscout/androidaps/activities/NoSplashAppCompatActivity.kt
similarity index 89%
rename from app/src/main/java/info/nightscout/androidaps/activities/NoSplashAppCompatActivity.kt
rename to core/src/main/java/info/nightscout/androidaps/activities/NoSplashAppCompatActivity.kt
index aaf85c6adf..060f1a8c2e 100644
--- a/app/src/main/java/info/nightscout/androidaps/activities/NoSplashAppCompatActivity.kt
+++ b/core/src/main/java/info/nightscout/androidaps/activities/NoSplashAppCompatActivity.kt
@@ -3,10 +3,10 @@ package info.nightscout.androidaps.activities
 import android.content.Context
 import android.os.Bundle
 import dagger.android.support.DaggerAppCompatActivity
-import info.nightscout.androidaps.R
+import info.nightscout.androidaps.core.R
 import info.nightscout.androidaps.utils.LocaleHelper
 
-@Suppress("registered")
+//@Suppress("registered")
 open class NoSplashAppCompatActivity : DaggerAppCompatActivity() {
 
     public override fun onCreate(savedInstanceState: Bundle?) {
diff --git a/app/src/main/java/info/nightscout/androidaps/utils/LocaleHelper.kt b/core/src/main/java/info/nightscout/androidaps/utils/locale/LocaleHelper.kt
similarity index 98%
rename from app/src/main/java/info/nightscout/androidaps/utils/LocaleHelper.kt
rename to core/src/main/java/info/nightscout/androidaps/utils/locale/LocaleHelper.kt
index 62da88a15d..7180bf7927 100644
--- a/app/src/main/java/info/nightscout/androidaps/utils/LocaleHelper.kt
+++ b/core/src/main/java/info/nightscout/androidaps/utils/locale/LocaleHelper.kt
@@ -5,7 +5,7 @@ import android.content.ContextWrapper
 import android.os.Build
 import android.os.LocaleList
 import androidx.preference.PreferenceManager
-import info.nightscout.androidaps.R
+import info.nightscout.androidaps.core.R
 import java.util.*
 
 object LocaleHelper {
diff --git a/core/src/main/res/values/layout.xml b/core/src/main/res/values/layout.xml
index 57f058c48b..dcd51d9ab7 100644
--- a/core/src/main/res/values/layout.xml
+++ b/core/src/main/res/values/layout.xml
@@ -1,3 +1,10 @@
 <resources>
     <bool name="isTablet">false</bool>
+
+    <style name="AppTheme.NoActionBar" parent="Theme.AppCompat.NoActionBar">
+        <item name="colorPrimary">@color/colorPrimary</item>
+        <item name="colorPrimaryDark">@color/colorPrimaryDark</item>
+        <item name="colorAccent">@color/colorAccent</item>
+    </style>
+
 </resources>
\ No newline at end of file
diff --git a/core/src/main/res/values/strings.xml b/core/src/main/res/values/strings.xml
index a0d615ea71..be67629d42 100644
--- a/core/src/main/res/values/strings.xml
+++ b/core/src/main/res/values/strings.xml
@@ -1,6 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
     <string name="key_enable_fabric" translatable="false">enable_fabric</string>
+    <string name="key_language" translatable="false">language</string>
+
     <string name="confirmation">Confirmation</string>
     <string name="message">Message</string>
     <string name="ok">OK</string>