From 193814c739ed9675ec5f944002f8ee272ee943e0 Mon Sep 17 00:00:00 2001 From: Milos Kozak Date: Tue, 26 Apr 2022 11:13:17 +0200 Subject: [PATCH 1/8] lint --- .../androidaps/plugins/constraints/safety/SafetyPlugin.kt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/info/nightscout/androidaps/plugins/constraints/safety/SafetyPlugin.kt b/app/src/main/java/info/nightscout/androidaps/plugins/constraints/safety/SafetyPlugin.kt index a91cf4fe54..80d6728b82 100644 --- a/app/src/main/java/info/nightscout/androidaps/plugins/constraints/safety/SafetyPlugin.kt +++ b/app/src/main/java/info/nightscout/androidaps/plugins/constraints/safety/SafetyPlugin.kt @@ -37,7 +37,7 @@ class SafetyPlugin @Inject constructor( private val constraintChecker: ConstraintChecker, private val openAPSAMAPlugin: OpenAPSAMAPlugin, private val openAPSSMBPlugin: OpenAPSSMBPlugin, - private val OpenAPSSMBDynamicISFPlugin: OpenAPSSMBDynamicISFPlugin, + private val openAPSSMBDynamicISFPlugin: OpenAPSSMBDynamicISFPlugin, private val sensitivityOref1Plugin: SensitivityOref1Plugin, private val activePlugin: ActivePlugin, private val hardLimits: HardLimits, @@ -190,12 +190,12 @@ class SafetyPlugin @Inject constructor( override fun applyMaxIOBConstraints(maxIob: Constraint): Constraint { val apsMode = sp.getString(R.string.key_aps_mode, "open") - val maxIobPref: Double = if (openAPSSMBPlugin.isEnabled() || OpenAPSSMBDynamicISFPlugin.isEnabled()) sp.getDouble(R.string.key_openapssmb_max_iob, 3.0) else sp.getDouble(R.string + val maxIobPref: Double = if (openAPSSMBPlugin.isEnabled() || openAPSSMBDynamicISFPlugin.isEnabled()) sp.getDouble(R.string.key_openapssmb_max_iob, 3.0) else sp.getDouble(R.string .key_openapsma_max_iob, 1.5) maxIob.setIfSmaller(aapsLogger, maxIobPref, rh.gs(R.string.limitingiob, maxIobPref, rh.gs(R.string.maxvalueinpreferences)), this) if (openAPSAMAPlugin.isEnabled()) maxIob.setIfSmaller(aapsLogger, hardLimits.maxIobAMA(), rh.gs(R.string.limitingiob, hardLimits.maxIobAMA(), rh.gs(R.string.hardlimit)), this) if (openAPSSMBPlugin.isEnabled()) maxIob.setIfSmaller(aapsLogger, hardLimits.maxIobSMB(), rh.gs(R.string.limitingiob, hardLimits.maxIobSMB(), rh.gs(R.string.hardlimit)), this) - if (OpenAPSSMBDynamicISFPlugin.isEnabled()) maxIob.setIfSmaller(aapsLogger, hardLimits.maxIobSMB(), rh.gs(R.string.limitingiob, hardLimits.maxIobSMB(), rh.gs(R.string.hardlimit)), this) + if (openAPSSMBDynamicISFPlugin.isEnabled()) maxIob.setIfSmaller(aapsLogger, hardLimits.maxIobSMB(), rh.gs(R.string.limitingiob, hardLimits.maxIobSMB(), rh.gs(R.string.hardlimit)), this) if (apsMode == "lgs") maxIob.setIfSmaller(aapsLogger, HardLimits.MAX_IOB_LGS, rh.gs(R.string.limitingiob, HardLimits.MAX_IOB_LGS, rh.gs(R.string.lowglucosesuspend)), this) return maxIob } From 4ea3420cb52eab87ab9c08d804522767dfe8cefe Mon Sep 17 00:00:00 2001 From: Milos Kozak Date: Tue, 26 Apr 2022 11:23:30 +0200 Subject: [PATCH 2/8] lint --- .../androidaps/interfaces/DetermineBasalAdapterInterface.kt | 2 +- .../java/info/nightscout/androidaps/utils/ui/NumberPicker.kt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/info/nightscout/androidaps/interfaces/DetermineBasalAdapterInterface.kt b/core/src/main/java/info/nightscout/androidaps/interfaces/DetermineBasalAdapterInterface.kt index 4e1ba57422..9b8ed0d9c2 100644 --- a/core/src/main/java/info/nightscout/androidaps/interfaces/DetermineBasalAdapterInterface.kt +++ b/core/src/main/java/info/nightscout/androidaps/interfaces/DetermineBasalAdapterInterface.kt @@ -30,7 +30,7 @@ interface DetermineBasalAdapterInterface { uamAllowed: Boolean = false, advancedFiltering: Boolean = false, isSaveCgmSource: Boolean = false - ) {} + ) operator fun invoke(): APSResult? } \ No newline at end of file diff --git a/core/src/main/java/info/nightscout/androidaps/utils/ui/NumberPicker.kt b/core/src/main/java/info/nightscout/androidaps/utils/ui/NumberPicker.kt index b4cecb63f1..71d0b7c392 100644 --- a/core/src/main/java/info/nightscout/androidaps/utils/ui/NumberPicker.kt +++ b/core/src/main/java/info/nightscout/androidaps/utils/ui/NumberPicker.kt @@ -136,7 +136,7 @@ open class NumberPicker(context: Context, attrs: AttributeSet? = null) : LinearL } fun updateA11yDescription() { - val description = if (mCustomContentDescription != null) mCustomContentDescription else "" + val description = mCustomContentDescription ?: "" binding.minusButton.contentDescription = context.getString(R.string.a11y_min_button_description, description, formatter?.format(this.step)) binding.plusButton.contentDescription = context.getString(R.string.a11y_plus_button_description, description, formatter?.format(this.step)) } From a30c5d4a29d3d7ea1d86ae444345ed9781ab89f5 Mon Sep 17 00:00:00 2001 From: Milos Kozak Date: Tue, 26 Apr 2022 11:25:30 +0200 Subject: [PATCH 3/8] lint --- .../java/info/nightscout/androidaps/danar/comm/MessageBase.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/danar/src/main/java/info/nightscout/androidaps/danar/comm/MessageBase.kt b/danar/src/main/java/info/nightscout/androidaps/danar/comm/MessageBase.kt index 33007e943f..571db17cbf 100644 --- a/danar/src/main/java/info/nightscout/androidaps/danar/comm/MessageBase.kt +++ b/danar/src/main/java/info/nightscout/androidaps/danar/comm/MessageBase.kt @@ -122,7 +122,7 @@ open class MessageBase(injector: HasAndroidInjector) { } } - open fun handleMessageNotReceived() {} + open fun handleMessageNotReceived() {} // do nothing by default val command: Int get() = byteFromRawBuff(buffer, 5) or (byteFromRawBuff(buffer, 4) shl 8) From 8edb23069a4d41e7658d6773eaebd74de004d5ec Mon Sep 17 00:00:00 2001 From: Milos Kozak Date: Tue, 26 Apr 2022 11:28:36 +0200 Subject: [PATCH 4/8] lint --- .../plugins/pump/insight/activities/InsightPairingActivity.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/insight/src/main/java/info/nightscout/androidaps/plugins/pump/insight/activities/InsightPairingActivity.java b/insight/src/main/java/info/nightscout/androidaps/plugins/pump/insight/activities/InsightPairingActivity.java index 65d8185d26..97a5c9dfbe 100644 --- a/insight/src/main/java/info/nightscout/androidaps/plugins/pump/insight/activities/InsightPairingActivity.java +++ b/insight/src/main/java/info/nightscout/androidaps/plugins/pump/insight/activities/InsightPairingActivity.java @@ -58,7 +58,7 @@ public class InsightPairingActivity extends NoSplashAppCompatActivity implements private RecyclerView deviceList; private final DeviceAdapter deviceAdapter = new DeviceAdapter(); - private final int PERMISSION_REQUEST_BLUETOOTH = 30242; + private static final int PERMISSION_REQUEST_BLUETOOTH = 30242; private InsightConnectionService service; From 8dde3bcfa4be0382b840270b233022e60f57c881 Mon Sep 17 00:00:00 2001 From: Milos Kozak Date: Tue, 26 Apr 2022 11:44:32 +0200 Subject: [PATCH 5/8] lint --- .../main/java/info/nightscout/androidaps/skins/SkinInterface.kt | 1 + 1 file changed, 1 insertion(+) diff --git a/app/src/main/java/info/nightscout/androidaps/skins/SkinInterface.kt b/app/src/main/java/info/nightscout/androidaps/skins/SkinInterface.kt index 3ef7501ae4..2e338955d5 100644 --- a/app/src/main/java/info/nightscout/androidaps/skins/SkinInterface.kt +++ b/app/src/main/java/info/nightscout/androidaps/skins/SkinInterface.kt @@ -17,6 +17,7 @@ interface SkinInterface { val mainGraphHeight: Int // in dp val secondaryGraphHeight: Int // in dp + // no pre processing by default fun preProcessLandscapeActionsLayout(dm: DisplayMetrics, binding: ActionsFragmentBinding) { } From 296fe300529ce2d7940d9911886f331294f56cb4 Mon Sep 17 00:00:00 2001 From: Milos Kozak Date: Tue, 26 Apr 2022 12:28:12 +0200 Subject: [PATCH 6/8] SMB: add log --- .../info/nightscout/androidaps/plugins/aps/loop/LoopPlugin.kt | 1 + 1 file changed, 1 insertion(+) diff --git a/app/src/main/java/info/nightscout/androidaps/plugins/aps/loop/LoopPlugin.kt b/app/src/main/java/info/nightscout/androidaps/plugins/aps/loop/LoopPlugin.kt index fa8c085404..89f394f696 100644 --- a/app/src/main/java/info/nightscout/androidaps/plugins/aps/loop/LoopPlugin.kt +++ b/app/src/main/java/info/nightscout/androidaps/plugins/aps/loop/LoopPlugin.kt @@ -588,6 +588,7 @@ class LoopPlugin @Inject constructor( private fun applySMBRequest(request: APSResult, callback: Callback?) { if (!request.bolusRequested()) { + aapsLogger.debug(LTag.APS, "No SMB requested") return } val pump = activePlugin.activePump From 8249118a149f0659d8065473983a1d2cd315d144 Mon Sep 17 00:00:00 2001 From: osodebailar Date: Tue, 26 Apr 2022 19:34:13 +0200 Subject: [PATCH 7/8] improve localprofile on entry --- app/src/main/res/layout/localprofile_fragment.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/src/main/res/layout/localprofile_fragment.xml b/app/src/main/res/layout/localprofile_fragment.xml index f1bd26f410..ff453c53e0 100644 --- a/app/src/main/res/layout/localprofile_fragment.xml +++ b/app/src/main/res/layout/localprofile_fragment.xml @@ -302,6 +302,7 @@ android:paddingStart="10dp" android:paddingEnd="10dp" android:text="@string/activate_profile" + android:visibility="gone" app:icon="@drawable/ic_local_activate" app:iconTint="@color/ic_local_activate" /> @@ -323,6 +324,7 @@ android:paddingStart="1dp" android:paddingEnd="1dp" android:text="@string/reset" + android:visibility="gone" app:icon="@drawable/ic_local_reset" app:iconTint="@color/ic_local_reset" /> @@ -338,6 +340,7 @@ android:paddingStart="1dp" android:paddingEnd="1dp" android:text="@string/save" + android:visibility="gone" app:icon="@drawable/ic_local_save" app:iconTint="@color/ic_local_save" /> From ff34e9bdd2b071d456b412e7f856e10ee0cfa385 Mon Sep 17 00:00:00 2001 From: osodebailar Date: Tue, 26 Apr 2022 19:34:19 +0200 Subject: [PATCH 8/8] improve dana bottom buttons --- core/src/main/res/drawable/ic_danarstats.xml | 8 ++-- dana/src/main/res/layout/danar_fragment.xml | 39 ++++++++++++-------- 2 files changed, 28 insertions(+), 19 deletions(-) diff --git a/core/src/main/res/drawable/ic_danarstats.xml b/core/src/main/res/drawable/ic_danarstats.xml index 81b3952eb4..a95eef3884 100644 --- a/core/src/main/res/drawable/ic_danarstats.xml +++ b/core/src/main/res/drawable/ic_danarstats.xml @@ -7,24 +7,24 @@ android:pathData="M5.719,19.125L5.719,11.828" android:strokeWidth="2.2677" android:fillColor="#00000000" - android:strokeColor="#FEAF05" + android:strokeColor="?attr/statsColor" android:strokeLineCap="round"/> diff --git a/dana/src/main/res/layout/danar_fragment.xml b/dana/src/main/res/layout/danar_fragment.xml index e26919aebd..8cc0d95305 100644 --- a/dana/src/main/res/layout/danar_fragment.xml +++ b/dana/src/main/res/layout/danar_fragment.xml @@ -2,6 +2,7 @@ xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="match_parent" + xmlns:app="http://schemas.android.com/apk/res-auto" tools:context="info.nightscout.androidaps.dana.DanaFragment" android:orientation="vertical"> @@ -658,50 +659,58 @@ android:layout_height="wrap_content" android:orientation="horizontal"> - + android:text="@string/viewprofile" + android:maxLines="2" + android:ellipsize="end" + app:iconPadding="-4dp"/> - - + android:text="@string/stats" + android:maxLines="2" + android:ellipsize="end" + app:iconPadding="-4dp"/> - + android:text="@string/danar_useroptions" + android:maxLines="2" + android:ellipsize="end" + app:iconPadding="-4dp"/>