caspervk/AndroidAPS
1
0
Fork 0
Code Releases Activity

Merge pull request #1508 from jotomo/fabric-attributes

Browse source 
Fabric: don't report disabled plugins.
This commit is contained in:
Milos Kozak 2018-10-17 22:33:59 +02:00 committed by GitHub
commit 786a91f7e1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/src/main/java/info/nightscout/utils/FabricPrivacy.java
View file

@ -112,11 +112,11 @@ public class FabricPrivacy {
pluginStats.putCustomAttribute("HEAD", BuildConfig.HEAD); pluginStats.putCustomAttribute("HEAD", BuildConfig.HEAD);
pluginStats.putCustomAttribute("language", SP.getString(R.string.key_language,"default")); pluginStats.putCustomAttribute("language", SP.getString(R.string.key_language,"default"));
for (PluginBase plugin : MainApp.getPluginsList()) { for (PluginBase plugin : MainApp.getPluginsList()) {
if (!plugin.pluginDescription.alwaysEnabled) { if (plugin.isEnabled(plugin.getType()) && !plugin.pluginDescription.alwaysEnabled) {
if (plugin.isEnabled(plugin.getType())) // Fabric allows no more than 20 attributes attached to an event. By reporting disabled plugins as
// well, we would exceed that threshold, so only report what is enabled
// TODO >2.0: consider reworking this to upload an event per enabled plugin instead.
pluginStats.putCustomAttribute(plugin.getClass().getSimpleName(), "enabled"); pluginStats.putCustomAttribute(plugin.getClass().getSimpleName(), "enabled");
else
pluginStats.putCustomAttribute(plugin.getClass().getSimpleName(), "disabled");
} }
} }