From 66062e3ee65ade0968a2c1ab47121fedb907d930 Mon Sep 17 00:00:00 2001
From: Bart Sopers <bart@sopers.nl>
Date: Sun, 6 Sep 2020 16:44:47 +0200
Subject: [PATCH] Remove unnecessary method injection

---
 .../androidaps/plugins/pump/omnipod/dagger/OmnipodModule.kt   | 2 --
 .../plugins/pump/omnipod/manager/AapsOmnipodManager.java      | 4 ----
 2 files changed, 6 deletions(-)

diff --git a/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/dagger/OmnipodModule.kt b/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/dagger/OmnipodModule.kt
index 8841fb2645..225b1bb5ca 100644
--- a/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/dagger/OmnipodModule.kt
+++ b/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/dagger/OmnipodModule.kt
@@ -5,7 +5,6 @@ import dagger.Provides
 import dagger.android.ContributesAndroidInjector
 import info.nightscout.androidaps.plugins.pump.omnipod.data.RLHistoryItemOmnipod
 import info.nightscout.androidaps.plugins.pump.omnipod.driver.manager.PodStateManager
-import info.nightscout.androidaps.plugins.pump.omnipod.manager.AapsOmnipodManager
 import info.nightscout.androidaps.plugins.pump.omnipod.manager.AapsPodStateManager
 import info.nightscout.androidaps.plugins.pump.omnipod.rileylink.manager.OmnipodRileyLinkCommunicationManager
 import info.nightscout.androidaps.plugins.pump.omnipod.ui.PodHistoryActivity
@@ -33,7 +32,6 @@ abstract class OmnipodModule {
     // Service
     @ContributesAndroidInjector
     abstract fun omnipodCommunicationManagerProvider(): OmnipodRileyLinkCommunicationManager
-    @ContributesAndroidInjector abstract fun aapsOmnipodManagerProvider(): AapsOmnipodManager
 
     // Data
     @ContributesAndroidInjector abstract fun initPodRefreshAction(): InitPodRefreshAction
diff --git a/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/manager/AapsOmnipodManager.java b/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/manager/AapsOmnipodManager.java
index 6d05f79c7c..97a2123d76 100644
--- a/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/manager/AapsOmnipodManager.java
+++ b/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/manager/AapsOmnipodManager.java
@@ -128,11 +128,7 @@ public class AapsOmnipodManager {
         this.omnipodAlertUtil = omnipodAlertUtil;
 
         delegate = new OmnipodManager(aapsLogger, sp, communicationService, podStateManager);
-    }
 
-    @Inject
-    void onInit() {
-        // this cannot be done in the constructor, as sp is not populated at that time
         reloadSettings();
     }