diff --git a/app/src/main/java/info/nightscout/androidaps/plugins/pump/danaR/comm/MsgBolusStart.kt b/app/src/main/java/info/nightscout/androidaps/plugins/pump/danaR/comm/MsgBolusStart.kt index bfb55661ab..695c3f1ec0 100644 --- a/app/src/main/java/info/nightscout/androidaps/plugins/pump/danaR/comm/MsgBolusStart.kt +++ b/app/src/main/java/info/nightscout/androidaps/plugins/pump/danaR/comm/MsgBolusStart.kt @@ -28,6 +28,7 @@ class MsgBolusStart( failed = true aapsLogger.debug(LTag.PUMPBTCOMM, "Messsage response: $errorCode FAILED!!") } else { + failed = false aapsLogger.debug(LTag.PUMPBTCOMM, "Messsage response: $errorCode OK") } danaRPump.messageStartErrorCode = errorCode diff --git a/app/src/main/java/info/nightscout/androidaps/plugins/pump/danaR/comm/MsgBolusStartWithSpeed.kt b/app/src/main/java/info/nightscout/androidaps/plugins/pump/danaR/comm/MsgBolusStartWithSpeed.kt index f8490121ef..3ea3eed8f1 100644 --- a/app/src/main/java/info/nightscout/androidaps/plugins/pump/danaR/comm/MsgBolusStartWithSpeed.kt +++ b/app/src/main/java/info/nightscout/androidaps/plugins/pump/danaR/comm/MsgBolusStartWithSpeed.kt @@ -30,6 +30,7 @@ class MsgBolusStartWithSpeed( failed = true aapsLogger.debug(LTag.PUMPBTCOMM, "Messsage response: $errorCode FAILED!!") } else { + failed = false aapsLogger.debug(LTag.PUMPBTCOMM, "Messsage response: $errorCode OK") } danaRPump.messageStartErrorCode = errorCode diff --git a/app/src/main/java/info/nightscout/androidaps/plugins/pump/danaRv2/comm/MsgHistoryEvents_v2.kt b/app/src/main/java/info/nightscout/androidaps/plugins/pump/danaRv2/comm/MsgHistoryEvents_v2.kt index 25720157b5..ffb9c6a9f3 100644 --- a/app/src/main/java/info/nightscout/androidaps/plugins/pump/danaRv2/comm/MsgHistoryEvents_v2.kt +++ b/app/src/main/java/info/nightscout/androidaps/plugins/pump/danaRv2/comm/MsgHistoryEvents_v2.kt @@ -57,6 +57,7 @@ class MsgHistoryEvents_v2 constructor( danaRv2Plugin.eventsLoadingDone = true return } + danaRv2Plugin.eventsLoadingDone = false val datetime = dateTimeSecFromBuff(bytes, 1) // 6 bytes val param1 = intFromBuff(bytes, 7, 2) val param2 = intFromBuff(bytes, 9, 2) diff --git a/app/src/test/java/info/nightscout/androidaps/plugins/pump/danaR/comm/DanaRTestBase.kt b/app/src/test/java/info/nightscout/androidaps/plugins/pump/danaR/comm/DanaRTestBase.kt new file mode 100644 index 0000000000..9a1ed6b487 --- /dev/null +++ b/app/src/test/java/info/nightscout/androidaps/plugins/pump/danaR/comm/DanaRTestBase.kt @@ -0,0 +1,50 @@ +package info.nightscout.androidaps.plugins.pump.danaR.comm + +import dagger.android.HasAndroidInjector +import info.nightscout.androidaps.TestBase +import info.nightscout.androidaps.logging.AAPSLogger +import info.nightscout.androidaps.plugins.pump.danaR.DanaRPump +import info.nightscout.androidaps.utils.sharedPreferences.SP +import org.junit.Before +import org.mockito.Mock + +open class DanaRTestBase : TestBase() { + + @Mock lateinit var aapsLogger: AAPSLogger + @Mock lateinit var sp: SP + @Mock lateinit var injector: HasAndroidInjector + + lateinit var danaRPump: DanaRPump + + fun createArray(length: Int, fillWith: Byte): ByteArray { + val ret = ByteArray(length) + for (i in 0 until length) { + ret[i] = fillWith + } + return ret + } + + fun createArray(length: Int, fillWith: Double): Array { + val ret = Array(length) { 0.0 } + for (i in 0 until length) { + ret[i] = fillWith + } + return ret + } + + fun putIntToArray(array: ByteArray, position: Int, value: Int): ByteArray { + array[6 + position + 1] = (value and 0xFF).toByte() + array[6 + position] = ((value and 0xFF00) shr 8).toByte() + return array + } + + fun putByteToArray(array: ByteArray, position: Int, value: Byte): ByteArray { + array[6 + position] = value + return array + } + + @Before + fun setup() { + danaRPump = DanaRPump(aapsLogger, sp, injector) + } +} \ No newline at end of file diff --git a/app/src/test/java/info/nightscout/androidaps/plugins/pump/danaR/comm/MsgBolusProgressTest.java b/app/src/test/java/info/nightscout/androidaps/plugins/pump/danaR/comm/MsgBolusProgressTest.java deleted file mode 100644 index 289df3d186..0000000000 --- a/app/src/test/java/info/nightscout/androidaps/plugins/pump/danaR/comm/MsgBolusProgressTest.java +++ /dev/null @@ -1,57 +0,0 @@ -package info.nightscout.androidaps.plugins.pump.danaR.comm; - -import org.junit.Test; -import org.junit.runner.RunWith; -import org.powermock.core.classloader.annotations.PrepareForTest; -import org.powermock.modules.junit4.PowerMockRunner; - -import info.AAPSMocker; -import info.nightscout.androidaps.MainApp; -import info.nightscout.androidaps.logging.L; -import info.nightscout.androidaps.plugins.treatments.Treatment; -import info.nightscout.androidaps.utils.SP; - -import static org.junit.Assert.assertEquals; - -/** - * Created by Rumen Georgiev on 8/28/2018. - */ - -@RunWith(PowerMockRunner.class) -@PrepareForTest({MainApp.class, SP.class, L.class}) -public class MsgBolusProgressTest { - @Test - public void runTest() { - AAPSMocker.mockMainApp(); - AAPSMocker.mockApplicationContext(); - AAPSMocker.mockSP(); - AAPSMocker.mockL(); - AAPSMocker.mockStrings(); - Treatment t = new Treatment(); - MsgBolusProgress packet = new MsgBolusProgress(3D, t); - - // test message decoding - packet.handleMessage(createArray(34, (byte) 1)); - - int valueRequested = (((byte) 1 << 8) + ((byte) 1 + 0)); - assertEquals(valueRequested, packet.progress,0d); - - } - - byte[] createArray(int length, byte fillWith){ - byte[] ret = new byte[length]; - for(int i = 0; i