caspervk/AndroidAPS
1
0
Fork 0
Code Releases Activity

dash ble: add comment about why I think the NACK logic is not ok

Browse source
This commit is contained in:
Andrei Vereha 2021-03-14 20:32:32 +01:00
parent 109f66a48d
commit 442a0b274f
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
omnipod-dash/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/dash/driver/comm/message/MessageIO.kt
View file

@ -67,6 +67,13 @@ class MessageIO(private val aapsLogger: AAPSLogger, private val bleIO: BleIO) {
aapsLogger.debug(LTag.PUMPBTCOMM, "Sending DATA: ${packet.toByteArray().toHex()}")
bleIO.sendAndConfirmPacket(CharacteristicType.DATA, packet.toByteArray())
peekForNack(index, packets)
// This is implementing the same logic as the PDM.
// I think it wil not work in case of packet lost.
// This is because each lost packet, we will receive a NACK on the next packet.
// At the end, we will still be missing the last packet(s).
// I don't worry too much about this because for commands we have retries implemented at MessagePacket level anyway
// If this will be a problem in the future, the fix might be(pending testing with a real pod) to move back the index
// at the value received in the NACK and make sure don't retry forever.
}
val expectSuccess = bleIO.receivePacket(CharacteristicType.CMD)
expectCommandType(BleCommand(expectSuccess), BleCommandSuccess())