caspervk/AndroidAPS
1
0
Fork 0
Code Releases Activity

Rewrites GetDeviceTypePacketTest with matchers

Browse source 
Issue #2745
This commit is contained in:
Ryan Haining 2023-10-08 17:01:20 -07:00
parent d39a23977d
commit 3e8455ad2e
1 changed files with 10 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
pump/medtrum/src/test/java/info/nightscout/pump/medtrum/comm/packets/GetDeviceTypePacketTest.kt
View file

@ -1,10 +1,10 @@
package info.nightscout.pump.medtrum.comm.packets package info.nightscout.pump.medtrum.comm.packets
import com.google.common.truth.Truth.assertThat
import dagger.android.AndroidInjector import dagger.android.AndroidInjector
import dagger.android.HasAndroidInjector import dagger.android.HasAndroidInjector
import info.nightscout.pump.medtrum.MedtrumTestBase import info.nightscout.pump.medtrum.MedtrumTestBase
import info.nightscout.pump.medtrum.extension.toByteArray import info.nightscout.pump.medtrum.extension.toByteArray
import org.junit.jupiter.api.Assertions
import org.junit.jupiter.api.Test import org.junit.jupiter.api.Test
class GetDeviceTypePacketTest : MedtrumTestBase() { class GetDeviceTypePacketTest : MedtrumTestBase() {
@ -28,8 +28,7 @@ class GetDeviceTypePacketTest : MedtrumTestBase() {
val result = packet.getRequest() val result = packet.getRequest()
// Expected values // Expected values
Assertions.assertEquals(1, result.size) assertThat(result).asList().containsExactly(opCode.toByte())
Assertions.assertEquals(opCode.toByte(), result[0])
} }
@Test fun handleResponseGivenResponseWhenMessageIsCorrectLengthThenResultTrue() { @Test fun handleResponseGivenResponseWhenMessageIsCorrectLengthThenResultTrue() {
@ -45,10 +44,10 @@ class GetDeviceTypePacketTest : MedtrumTestBase() {
val result = packet.handleResponse(response) val result = packet.handleResponse(response)
// Expected values // Expected values
Assertions.assertEquals(true, result) assertThat(result).isTrue()
Assertions.assertEquals(false, packet.failed) assertThat(packet.failed).isFalse()
Assertions.assertEquals(deviceType, packet.deviceType) assertThat(packet.deviceType).isEqualTo(deviceType)
Assertions.assertEquals(deviceSN, packet.deviceSN) assertThat(packet.deviceSN).isEqualTo(deviceSN)
} }
@ -65,9 +64,9 @@ class GetDeviceTypePacketTest : MedtrumTestBase() {
val result = packet.handleResponse(response.sliceArray(0..response.size - 2)) val result = packet.handleResponse(response.sliceArray(0..response.size - 2))
// Expected values // Expected values
Assertions.assertEquals(false, result) assertThat(result).isFalse()
Assertions.assertEquals(true, packet.failed) assertThat(packet.failed).isTrue()
Assertions.assertEquals(0, packet.deviceType) assertThat(packet.deviceType).isEqualTo(0)
Assertions.assertEquals(0, packet.deviceSN) assertThat(packet.deviceSN).isEqualTo(0)
} }
} }