From 468b645486e42e8a6f5ebaa6be51745b13c0c4e2 Mon Sep 17 00:00:00 2001 From: "Markus M. May" Date: Thu, 28 Jun 2018 22:36:08 +0200 Subject: [PATCH 1/7] Do calculations in a central place --- .../androidaps/plugins/Overview/OverviewFragment.java | 8 ++++---- app/src/main/java/info/nightscout/utils/DateUtil.java | 4 ++++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/info/nightscout/androidaps/plugins/Overview/OverviewFragment.java b/app/src/main/java/info/nightscout/androidaps/plugins/Overview/OverviewFragment.java index eb13cf5ef8..d1cbf71c05 100644 --- a/app/src/main/java/info/nightscout/androidaps/plugins/Overview/OverviewFragment.java +++ b/app/src/main/java/info/nightscout/androidaps/plugins/Overview/OverviewFragment.java @@ -839,7 +839,7 @@ public class OverviewFragment extends Fragment implements View.OnClickListener, if (wizard.superBolus) { final LoopPlugin loopPlugin = LoopPlugin.getPlugin(); if (loopPlugin.isEnabled(PluginType.LOOP)) { - loopPlugin.superBolusTo(System.currentTimeMillis() + 2 * 60L * 60 * 1000); + loopPlugin.superBolusTo(System.currentTimeMillis() + DateUtil.hourToMs(2)); MainApp.bus().post(new EventRefreshOverview("WizardDialog")); } ConfigBuilderPlugin.getCommandQueue().tempBasalPercent(0, 120, true, profile, new Callback() { @@ -1426,12 +1426,12 @@ public class OverviewFragment extends Fragment implements View.OnClickListener, predHours = Math.max(0, predHours); hoursToFetch = rangeToDisplay - predHours; toTime = calendar.getTimeInMillis() + 100000; // little bit more to avoid wrong rounding - Graphview specific - fromTime = toTime - hoursToFetch * 60 * 60 * 1000L; - endTime = toTime + predHours * 60 * 60 * 1000L; + fromTime = toTime - DateUtil.hourToMs(hoursToFetch); + endTime = toTime + DateUtil.hourToMs(predHours); } else { hoursToFetch = rangeToDisplay; toTime = calendar.getTimeInMillis() + 100000; // little bit more to avoid wrong rounding - Graphview specific - fromTime = toTime - hoursToFetch * 60 * 60 * 1000L; + fromTime = toTime - DateUtil.hourToMs(hoursToFetch); endTime = toTime; } diff --git a/app/src/main/java/info/nightscout/utils/DateUtil.java b/app/src/main/java/info/nightscout/utils/DateUtil.java index 7d7db3f5a7..ca13381e37 100644 --- a/app/src/main/java/info/nightscout/utils/DateUtil.java +++ b/app/src/main/java/info/nightscout/utils/DateUtil.java @@ -180,4 +180,8 @@ public class DateUtil { return date - date % 1000; } + public static long hourToMs(long hour) { + return hour * 60 * 60 * 1000L; + } + } From 6bc60cd8a850fe0911d2b1479beea953216be3a4 Mon Sep 17 00:00:00 2001 From: "Markus M. May" Date: Sun, 1 Jul 2018 13:50:37 +0200 Subject: [PATCH 2/7] Rework to use already existing method --- .../androidaps/plugins/Overview/OverviewFragment.java | 9 +++++---- app/src/main/java/info/nightscout/utils/DateUtil.java | 5 ----- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/app/src/main/java/info/nightscout/androidaps/plugins/Overview/OverviewFragment.java b/app/src/main/java/info/nightscout/androidaps/plugins/Overview/OverviewFragment.java index d1cbf71c05..c1f6f5b82d 100644 --- a/app/src/main/java/info/nightscout/androidaps/plugins/Overview/OverviewFragment.java +++ b/app/src/main/java/info/nightscout/androidaps/plugins/Overview/OverviewFragment.java @@ -119,6 +119,7 @@ import info.nightscout.utils.OKDialog; import info.nightscout.utils.Profiler; import info.nightscout.utils.SP; import info.nightscout.utils.SingleClickButton; +import info.nightscout.utils.T; import info.nightscout.utils.ToastUtils; import static info.nightscout.utils.DateUtil.now; @@ -839,7 +840,7 @@ public class OverviewFragment extends Fragment implements View.OnClickListener, if (wizard.superBolus) { final LoopPlugin loopPlugin = LoopPlugin.getPlugin(); if (loopPlugin.isEnabled(PluginType.LOOP)) { - loopPlugin.superBolusTo(System.currentTimeMillis() + DateUtil.hourToMs(2)); + loopPlugin.superBolusTo(System.currentTimeMillis() + T.hours(2).msecs()); MainApp.bus().post(new EventRefreshOverview("WizardDialog")); } ConfigBuilderPlugin.getCommandQueue().tempBasalPercent(0, 120, true, profile, new Callback() { @@ -1426,12 +1427,12 @@ public class OverviewFragment extends Fragment implements View.OnClickListener, predHours = Math.max(0, predHours); hoursToFetch = rangeToDisplay - predHours; toTime = calendar.getTimeInMillis() + 100000; // little bit more to avoid wrong rounding - Graphview specific - fromTime = toTime - DateUtil.hourToMs(hoursToFetch); - endTime = toTime + DateUtil.hourToMs(predHours); + fromTime = toTime - T.hours(hoursToFetch).msecs(); + endTime = toTime + T.hours(predHours).msecs(); } else { hoursToFetch = rangeToDisplay; toTime = calendar.getTimeInMillis() + 100000; // little bit more to avoid wrong rounding - Graphview specific - fromTime = toTime - DateUtil.hourToMs(hoursToFetch); + fromTime = toTime - T.hours(hoursToFetch).msecs(); endTime = toTime; } diff --git a/app/src/main/java/info/nightscout/utils/DateUtil.java b/app/src/main/java/info/nightscout/utils/DateUtil.java index ca13381e37..c2164fd40e 100644 --- a/app/src/main/java/info/nightscout/utils/DateUtil.java +++ b/app/src/main/java/info/nightscout/utils/DateUtil.java @@ -179,9 +179,4 @@ public class DateUtil { public static long roundDateToSec(long date) { return date - date % 1000; } - - public static long hourToMs(long hour) { - return hour * 60 * 60 * 1000L; - } - } From bb301717772025bd89bc245dbba35da1e1d7b279 Mon Sep 17 00:00:00 2001 From: Milos Kozak Date: Mon, 2 Jul 2018 10:53:09 +0200 Subject: [PATCH 3/7] fix typo in poctech driver --- .../java/info/nightscout/androidaps/Services/DataService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/info/nightscout/androidaps/Services/DataService.java b/app/src/main/java/info/nightscout/androidaps/Services/DataService.java index 9f3873cb93..ca7d760cc4 100644 --- a/app/src/main/java/info/nightscout/androidaps/Services/DataService.java +++ b/app/src/main/java/info/nightscout/androidaps/Services/DataService.java @@ -289,7 +289,7 @@ public class DataService extends IntentService { bgReading.direction = json.getString("direction"); bgReading.date = json.getLong("date"); bgReading.raw = json.getDouble("raw"); - if (JsonHelper.safeGetString(json, "utils", Constants.MGDL).equals("mmol/L")) + if (JsonHelper.safeGetString(json, "units", Constants.MGDL).equals("mmol/L")) bgReading.value = bgReading.value * Constants.MMOLL_TO_MGDL; boolean isNew = MainApp.getDbHelper().createIfNotExists(bgReading, "Poctech"); if (isNew && SP.getBoolean(R.string.key_dexcomg5_nsupload, false)) { From 4919986dc04153cfcc217c1b584764fb3a154c29 Mon Sep 17 00:00:00 2001 From: Milos Kozak Date: Mon, 2 Jul 2018 12:18:49 +0200 Subject: [PATCH 4/7] setup wizard for pumpcontrol --- .../androidaps/setupwizard/SWDefinition.java | 26 ++++++++++--------- 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/app/src/main/java/info/nightscout/androidaps/setupwizard/SWDefinition.java b/app/src/main/java/info/nightscout/androidaps/setupwizard/SWDefinition.java index a8402dc1a5..c1669b73d0 100644 --- a/app/src/main/java/info/nightscout/androidaps/setupwizard/SWDefinition.java +++ b/app/src/main/java/info/nightscout/androidaps/setupwizard/SWDefinition.java @@ -19,6 +19,7 @@ import java.util.ArrayList; import java.util.List; import info.nightscout.androidaps.BuildConfig; +import info.nightscout.androidaps.Config; import info.nightscout.androidaps.MainApp; import info.nightscout.androidaps.PreferencesActivity; import info.nightscout.androidaps.R; @@ -87,7 +88,7 @@ public class SWDefinition { } SWDefinition() { - if (BuildConfig.FLAVOR.equals("full")) + if (BuildConfig.FLAVOR.equals("full") || BuildConfig.FLAVOR.equals("pumpcontrol")) SWDefinitionFull(); else if (BuildConfig.FLAVOR.equals("nsclient")) SWDefinitionNSClient(); @@ -368,6 +369,7 @@ public class SWDefinition { }) .visibility(() -> MainApp.getConfigBuilder().getActiveAPS() != null && ((PluginBase) MainApp.getConfigBuilder().getActiveAPS()).getPreferencesId() > 0)) .validator(() -> MainApp.getConfigBuilder().getActiveAPS() != null) + .visibility(() -> Config.APS) ) .add(new SWScreen(R.string.configbuilder_loop) .skippable(false) @@ -386,7 +388,7 @@ public class SWDefinition { }) .visibility(() -> !LoopPlugin.getPlugin().isEnabled(PluginType.LOOP))) .validator(() -> LoopPlugin.getPlugin().isEnabled(PluginType.LOOP)) - .visibility(() -> !LoopPlugin.getPlugin().isEnabled(PluginType.LOOP)) + .visibility(() -> !LoopPlugin.getPlugin().isEnabled(PluginType.LOOP) && Config.APS) ) .add(new SWScreen(R.string.configbuilder_sensitivity) .skippable(false) @@ -428,18 +430,18 @@ public class SWDefinition { }) .visibility(() -> !ObjectivesPlugin.getPlugin().isFragmentVisible())) .validator(() -> ObjectivesPlugin.getPlugin().isEnabled(PluginType.CONSTRAINTS)) - .visibility(() -> !ObjectivesPlugin.getPlugin().isFragmentVisible()) + .visibility(() -> !ObjectivesPlugin.getPlugin().isFragmentVisible() && Config.APS) ) .add(new SWScreen(R.string.objectives) - .skippable(false) - .add(new SWInfotext() - .label(R.string.startobjective)) - .add(new SWBreak()) - .add(new SWFragment(this) - .add(new ObjectivesFragment())) - .validator(() -> ObjectivesPlugin.getPlugin().objectives.get(0).isStarted()) - .visibility(() -> !ObjectivesPlugin.getPlugin().objectives.get(0).isStarted()) - ) + .skippable(false) + .add(new SWInfotext() + .label(R.string.startobjective)) + .add(new SWBreak()) + .add(new SWFragment(this) + .add(new ObjectivesFragment())) + .validator(() -> ObjectivesPlugin.getPlugin().objectives.get(0).isStarted()) + .visibility(() -> !ObjectivesPlugin.getPlugin().objectives.get(0).isStarted() && Config.APS) + ) ; } From 917ddf0cbe0d453c2a0a899dc20c386f8ac7093e Mon Sep 17 00:00:00 2001 From: Milos Kozak Date: Mon, 2 Jul 2018 15:04:09 +0200 Subject: [PATCH 5/7] CS translations --- .../main/res/layout/activity_setupwizard.xml | 4 +- app/src/main/res/values-cs/strings.xml | 132 +++++++++++++++++- app/src/main/res/values-es/strings.xml | 2 +- app/src/main/res/values/strings.xml | 13 +- 4 files changed, 139 insertions(+), 12 deletions(-) diff --git a/app/src/main/res/layout/activity_setupwizard.xml b/app/src/main/res/layout/activity_setupwizard.xml index 79dd6ed6f7..8510abd33f 100644 --- a/app/src/main/res/layout/activity_setupwizard.xml +++ b/app/src/main/res/layout/activity_setupwizard.xml @@ -74,7 +74,7 @@ android:layout_height="wrap_content" android:background="@android:color/transparent" android:onClick="showPreviousPage" - android:text="@string/setupwizard_previous" + android:text="@string/previous_button" android:textColor="#FFFFFF" />