From 32637b97e018490e8b2fc6a6df1979cce6016d9e Mon Sep 17 00:00:00 2001
From: Milos Kozak <m.kozak@sysop.cz>
Date: Wed, 3 Feb 2021 23:58:57 +0100
Subject: [PATCH] Omnipod -> jetpack

---
 omnipod/build.gradle                          |  1 -
 .../fragment/AttachPodInfoFragment.kt         |  4 +-
 .../PodActivationActionFragmentBase.kt        | 18 +++++---
 .../common/fragment/ActionFragmentBase.kt     | 38 ++++++++--------
 .../common/fragment/InfoFragmentBase.kt       |  5 +--
 .../common/fragment/WizardFragmentBase.kt     | 43 +++++++++++--------
 .../fragment/DeactivatePodActionFragment.kt   |  9 ++--
 .../layout/omnipod_wizard_base_fragment.xml   | 12 ++++--
 .../res/layout/omnipod_wizard_nav_buttons.xml |  4 +-
 .../omnipod_wizard_progress_indication.xml    |  2 +-
 10 files changed, 76 insertions(+), 60 deletions(-)

diff --git a/omnipod/build.gradle b/omnipod/build.gradle
index 19eacc0d1d..c3b4f67e77 100644
--- a/omnipod/build.gradle
+++ b/omnipod/build.gradle
@@ -1,6 +1,5 @@
 apply plugin: 'com.android.library'
 apply plugin: 'kotlin-android'
-apply plugin: 'kotlin-android-extensions'
 apply plugin: 'kotlin-kapt'
 
 android {
diff --git a/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/activation/fragment/AttachPodInfoFragment.kt b/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/activation/fragment/AttachPodInfoFragment.kt
index 8fc2d30b65..a02462d5af 100644
--- a/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/activation/fragment/AttachPodInfoFragment.kt
+++ b/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/activation/fragment/AttachPodInfoFragment.kt
@@ -2,13 +2,13 @@ package info.nightscout.androidaps.plugins.pump.omnipod.ui.wizard.activation.fra
 
 import android.os.Bundle
 import android.view.View
+import android.widget.Button
 import androidx.annotation.IdRes
 import androidx.annotation.StringRes
 import androidx.appcompat.app.AlertDialog
 import androidx.navigation.fragment.findNavController
 import info.nightscout.androidaps.plugins.pump.omnipod.R
 import info.nightscout.androidaps.plugins.pump.omnipod.ui.wizard.common.fragment.InfoFragmentBase
-import kotlinx.android.synthetic.main.omnipod_wizard_nav_buttons.*
 
 class AttachPodInfoFragment : InfoFragmentBase() {
 
@@ -26,7 +26,7 @@ class AttachPodInfoFragment : InfoFragmentBase() {
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
 
-        omnipod_wizard_button_next.setOnClickListener {
+        view.findViewById<Button>(R.id.button_next).setOnClickListener {
             context?.let {
                 AlertDialog.Builder(it)
                     .setIcon(android.R.drawable.ic_dialog_alert)
diff --git a/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/activation/fragment/PodActivationActionFragmentBase.kt b/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/activation/fragment/PodActivationActionFragmentBase.kt
index 40c8e9fbc9..cea430f585 100644
--- a/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/activation/fragment/PodActivationActionFragmentBase.kt
+++ b/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/activation/fragment/PodActivationActionFragmentBase.kt
@@ -3,22 +3,28 @@ package info.nightscout.androidaps.plugins.pump.omnipod.ui.wizard.activation.fra
 import android.content.Intent
 import android.os.Bundle
 import android.view.View
+import android.widget.Button
+import info.nightscout.androidaps.plugins.pump.omnipod.R
 import info.nightscout.androidaps.plugins.pump.omnipod.driver.definition.ActivationProgress
 import info.nightscout.androidaps.plugins.pump.omnipod.driver.manager.PodStateManager
 import info.nightscout.androidaps.plugins.pump.omnipod.ui.wizard.common.fragment.ActionFragmentBase
 import info.nightscout.androidaps.plugins.pump.omnipod.ui.wizard.deactivation.PodDeactivationWizardActivity
-import kotlinx.android.synthetic.main.omnipod_wizard_action_page_fragment.*
 import javax.inject.Inject
 
 abstract class PodActivationActionFragmentBase : ActionFragmentBase() {
 
-    @Inject
-    protected lateinit var podStateManager: PodStateManager
+    @Inject protected lateinit var podStateManager: PodStateManager
+
+    private lateinit var buttonDeactivatePod: Button
+    private lateinit var buttonRetry: Button
 
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
 
-        omnipod_wizard_button_deactivate_pod.setOnClickListener {
+        buttonDeactivatePod = view.findViewById(R.id.omnipod_wizard_button_deactivate_pod)
+        buttonRetry = view.findViewById(R.id.omnipod_wizard_button_retry)
+
+        buttonDeactivatePod.setOnClickListener {
             activity?.let {
                 startActivity(Intent(it, PodDeactivationWizardActivity::class.java))
                 it.finish()
@@ -28,8 +34,8 @@ abstract class PodActivationActionFragmentBase : ActionFragmentBase() {
 
     override fun onActionFailure() {
         if ((podStateManager.isPodActivationTimeExceeded && podStateManager.activationProgress.isAtLeast(ActivationProgress.PAIRING_COMPLETED)) || podStateManager.isPodFaulted) {
-            omnipod_wizard_button_retry.visibility = View.GONE
-            omnipod_wizard_button_deactivate_pod.visibility = View.VISIBLE
+            buttonRetry.visibility = View.GONE
+            buttonDeactivatePod.visibility = View.VISIBLE
         }
     }
 }
\ No newline at end of file
diff --git a/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/common/fragment/ActionFragmentBase.kt b/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/common/fragment/ActionFragmentBase.kt
index a8167c4568..d15462c2eb 100644
--- a/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/common/fragment/ActionFragmentBase.kt
+++ b/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/common/fragment/ActionFragmentBase.kt
@@ -1,52 +1,52 @@
 package info.nightscout.androidaps.plugins.pump.omnipod.ui.wizard.common.fragment
 
+import android.annotation.SuppressLint
 import android.os.Bundle
 import android.view.View
+import android.widget.Button
 import androidx.annotation.LayoutRes
 import androidx.annotation.StringRes
-import androidx.lifecycle.Observer
 import info.nightscout.androidaps.plugins.pump.omnipod.R
 import info.nightscout.androidaps.plugins.pump.omnipod.ui.wizard.common.viewmodel.ActionViewModelBase
 import info.nightscout.androidaps.utils.extensions.toVisibility
-import kotlinx.android.synthetic.main.omnipod_wizard_action_page_fragment.*
-import kotlinx.android.synthetic.main.omnipod_wizard_nav_buttons.*
 
 abstract class ActionFragmentBase : WizardFragmentBase() {
 
     protected lateinit var viewModel: ActionViewModelBase
 
+    @SuppressLint("CutPasteId")
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
 
-        omnipod_wizard_button_next.isEnabled = false
-        omnipod_wizard_action_page_text.setText(getTextId())
+        binding.navButtonsLayout.buttonNext.isEnabled = false
+        view.findViewById<Button>(R.id.omnipod_wizard_action_page_text).setText(getTextId())
 
-        omnipod_wizard_button_retry.setOnClickListener { viewModel.executeAction() }
+        view.findViewById<Button>(R.id.omnipod_wizard_button_retry).setOnClickListener { viewModel.executeAction() }
 
-        viewModel.isActionExecutingLiveData.observe(viewLifecycleOwner, Observer { isExecuting ->
+        viewModel.isActionExecutingLiveData.observe(viewLifecycleOwner, { isExecuting ->
             if (isExecuting) {
-                omnipod_wizard_action_error.visibility = View.GONE
-                omnipod_wizard_button_deactivate_pod.visibility = View.GONE
-                omnipod_wizard_button_discard_pod.visibility = View.GONE
-                omnipod_wizard_button_retry.visibility = View.GONE
+                view.findViewById<Button>(R.id.omnipod_wizard_action_error).visibility = View.GONE
+                view.findViewById<Button>(R.id.omnipod_wizard_button_deactivate_pod).visibility = View.GONE
+                view.findViewById<Button>(R.id.omnipod_wizard_button_discard_pod).visibility = View.GONE
+                view.findViewById<Button>(R.id.omnipod_wizard_button_retry).visibility = View.GONE
             }
-            omnipod_wizard_action_progress_indication.visibility = isExecuting.toVisibility()
-            omnipod_wizard_button_cancel.isEnabled = !isExecuting
+            view.findViewById<Button>(R.id.omnipod_wizard_action_progress_indication).visibility = isExecuting.toVisibility()
+            view.findViewById<Button>(R.id.button_cancel).isEnabled = !isExecuting
         })
 
-        viewModel.actionResultLiveData.observe(viewLifecycleOwner, Observer { result ->
+        viewModel.actionResultLiveData.observe(viewLifecycleOwner, { result ->
             result?.let {
                 val isExecuting = isActionExecuting()
 
-                omnipod_wizard_button_next.isEnabled = result.success
-                omnipod_wizard_action_success.visibility = result.success.toVisibility()
-                omnipod_wizard_action_error.visibility = (!isExecuting && !result.success).toVisibility()
-                omnipod_wizard_button_retry.visibility = (!isExecuting && !result.success).toVisibility()
+                view.findViewById<Button>(R.id.button_next).isEnabled = result.success
+                view.findViewById<Button>(R.id.omnipod_wizard_action_success).visibility = result.success.toVisibility()
+                view.findViewById<Button>(R.id.omnipod_wizard_action_error).visibility = (!isExecuting && !result.success).toVisibility()
+                view.findViewById<Button>(R.id.omnipod_wizard_button_retry).visibility = (!isExecuting && !result.success).toVisibility()
 
                 if (result.success) {
                     onActionSuccess()
                 } else {
-                    omnipod_wizard_action_error.text = result.comment
+                    view.findViewById<Button>(R.id.omnipod_wizard_action_error).text = result.comment
                     onActionFailure()
                 }
             }
diff --git a/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/common/fragment/InfoFragmentBase.kt b/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/common/fragment/InfoFragmentBase.kt
index d1008a1bea..365d356246 100644
--- a/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/common/fragment/InfoFragmentBase.kt
+++ b/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/common/fragment/InfoFragmentBase.kt
@@ -2,17 +2,17 @@ package info.nightscout.androidaps.plugins.pump.omnipod.ui.wizard.common.fragmen
 
 import android.os.Bundle
 import android.view.View
+import android.widget.TextView
 import androidx.annotation.LayoutRes
 import androidx.annotation.StringRes
 import info.nightscout.androidaps.plugins.pump.omnipod.R
-import kotlinx.android.synthetic.main.omnipod_wizard_info_page_fragment.*
 
 abstract class InfoFragmentBase : WizardFragmentBase() {
 
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
 
-        omnipod_wizard_info_page_text.setText(getTextId())
+        view.findViewById<TextView>(R.id.omnipod_wizard_info_page_text).setText(getTextId())
     }
 
     @StringRes
@@ -22,5 +22,4 @@ abstract class InfoFragmentBase : WizardFragmentBase() {
     override fun getLayoutId(): Int {
         return R.layout.omnipod_wizard_info_page_fragment
     }
-
 }
\ No newline at end of file
diff --git a/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/common/fragment/WizardFragmentBase.kt b/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/common/fragment/WizardFragmentBase.kt
index 086273a938..280b785c72 100644
--- a/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/common/fragment/WizardFragmentBase.kt
+++ b/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/common/fragment/WizardFragmentBase.kt
@@ -5,50 +5,49 @@ import android.os.Bundle
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
-import android.view.ViewStub
 import androidx.annotation.IdRes
 import androidx.annotation.LayoutRes
 import androidx.annotation.StringRes
 import androidx.navigation.fragment.findNavController
 import dagger.android.support.DaggerFragment
 import info.nightscout.androidaps.plugins.pump.omnipod.R
+import info.nightscout.androidaps.plugins.pump.omnipod.databinding.OmnipodWizardBaseFragmentBinding
 import info.nightscout.androidaps.plugins.pump.omnipod.ui.wizard.common.activity.OmnipodWizardActivityBase
-import kotlinx.android.synthetic.main.omnipod_wizard_base_fragment.*
-import kotlinx.android.synthetic.main.omnipod_wizard_nav_buttons.*
-import kotlinx.android.synthetic.main.omnipod_wizard_progress_indication.*
 import kotlin.math.roundToInt
 
 abstract class WizardFragmentBase : DaggerFragment() {
 
-    override fun onCreateView(
-        inflater: LayoutInflater,
-        container: ViewGroup?,
-        savedInstanceState: Bundle?
-    ): View {
-        val baseView = inflater.inflate(R.layout.omnipod_wizard_base_fragment, container, false)
-        val contentView = baseView.findViewById<ViewStub>(R.id.omnipod_wizard_base_fragment_content)
-        contentView?.let {
+    var _binding: OmnipodWizardBaseFragmentBinding? = null
+
+    // This property is only valid between onCreateView and
+    // onDestroyView.
+    val binding get() = _binding!!
+
+    override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View {
+        _binding = OmnipodWizardBaseFragmentBinding.inflate(inflater, container, false)
+
+        binding.fragmentContent.let {
             it.layoutResource = getLayoutId()
             it.inflate()
         }
-        return baseView
+        return binding.root
     }
 
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
 
-        omnipod_wizard_base_fragment_title.setText(getTitleId())
+        binding.fragmentTitle.setText(getTitleId())
 
         val nextPage = getNextPageActionId()
 
         if (nextPage == null) {
-            omnipod_wizard_button_next.text = getString(R.string.omnipod_wizard_button_finish)
-            omnipod_wizard_button_next.backgroundTintList = ColorStateList.valueOf(resources.getColor(R.color.omnipod_wizard_finish_button, context?.theme))
+            binding.navButtonsLayout.buttonNext.text = getString(R.string.omnipod_wizard_button_finish)
+            binding.navButtonsLayout.buttonNext.backgroundTintList = ColorStateList.valueOf(resources.getColor(R.color.omnipod_wizard_finish_button, context?.theme))
         }
 
         updateProgressIndication()
 
-        omnipod_wizard_button_next.setOnClickListener {
+        binding.navButtonsLayout.buttonNext.setOnClickListener {
             if (nextPage == null) {
                 activity?.finish()
             } else {
@@ -56,11 +55,17 @@ abstract class WizardFragmentBase : DaggerFragment() {
             }
         }
 
-        omnipod_wizard_button_cancel.setOnClickListener {
+        binding.navButtonsLayout.buttonCancel.setOnClickListener {
             (activity as? OmnipodWizardActivityBase)?.exitActivityAfterConfirmation()
         }
     }
 
+    @Synchronized
+    override fun onDestroyView() {
+        super.onDestroyView()
+        _binding = null
+    }
+
     private fun updateProgressIndication() {
         (activity as? OmnipodWizardActivityBase)?.let {
             val numberOfSteps = it.getActualNumberOfSteps()
@@ -68,7 +73,7 @@ abstract class WizardFragmentBase : DaggerFragment() {
             val currentFragment = getIndex() - (it.getTotalDefinedNumberOfSteps() - numberOfSteps)
             val progressPercentage = (currentFragment / numberOfSteps.toDouble() * 100).roundToInt()
 
-            omnipod_wizard_progress_indication.progress = progressPercentage
+            binding.progressIndicationLayout.progressIndication.progress = progressPercentage
         }
     }
 
diff --git a/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/deactivation/fragment/DeactivatePodActionFragment.kt b/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/deactivation/fragment/DeactivatePodActionFragment.kt
index 59843bc180..ddcbec9bb1 100644
--- a/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/deactivation/fragment/DeactivatePodActionFragment.kt
+++ b/omnipod/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/ui/wizard/deactivation/fragment/DeactivatePodActionFragment.kt
@@ -2,6 +2,7 @@ package info.nightscout.androidaps.plugins.pump.omnipod.ui.wizard.deactivation.f
 
 import android.os.Bundle
 import android.view.View
+import android.widget.Button
 import androidx.annotation.IdRes
 import androidx.annotation.StringRes
 import androidx.appcompat.app.AlertDialog
@@ -14,7 +15,6 @@ import info.nightscout.androidaps.plugins.pump.omnipod.manager.AapsOmnipodManage
 import info.nightscout.androidaps.plugins.pump.omnipod.ui.wizard.common.fragment.ActionFragmentBase
 import info.nightscout.androidaps.plugins.pump.omnipod.ui.wizard.deactivation.viewmodel.DeactivatePodActionViewModel
 import info.nightscout.androidaps.utils.extensions.toVisibility
-import kotlinx.android.synthetic.main.omnipod_wizard_action_page_fragment.*
 import javax.inject.Inject
 
 class DeactivatePodActionFragment : ActionFragmentBase() {
@@ -26,6 +26,8 @@ class DeactivatePodActionFragment : ActionFragmentBase() {
     @Inject
     lateinit var aapsOmnipodManager: AapsOmnipodManager
 
+    private lateinit var buttonDiscardPod: Button
+
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
 
@@ -35,7 +37,8 @@ class DeactivatePodActionFragment : ActionFragmentBase() {
 
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
-        omnipod_wizard_button_discard_pod.setOnClickListener {
+        buttonDiscardPod = view.findViewById(R.id.button_discard_pod)
+        buttonDiscardPod.setOnClickListener {
             context?.let {
                 AlertDialog.Builder(it)
                     .setIcon(android.R.drawable.ic_dialog_alert)
@@ -52,7 +55,7 @@ class DeactivatePodActionFragment : ActionFragmentBase() {
     }
 
     override fun onActionFailure() {
-        omnipod_wizard_button_discard_pod.visibility = (!isActionExecuting()).toVisibility()
+        buttonDiscardPod.visibility = (!isActionExecuting()).toVisibility()
     }
 
     @StringRes
diff --git a/omnipod/src/main/res/layout/omnipod_wizard_base_fragment.xml b/omnipod/src/main/res/layout/omnipod_wizard_base_fragment.xml
index f0e9649066..29e6864534 100644
--- a/omnipod/src/main/res/layout/omnipod_wizard_base_fragment.xml
+++ b/omnipod/src/main/res/layout/omnipod_wizard_base_fragment.xml
@@ -5,10 +5,12 @@
     android:layout_height="match_parent"
     android:orientation="vertical">
 
-    <include layout="@layout/omnipod_wizard_progress_indication" />
+    <include
+        android:id="@+id/progress_indication_layout"
+        layout="@layout/omnipod_wizard_progress_indication" />
 
     <TextView
-        android:id="@+id/omnipod_wizard_base_fragment_title"
+        android:id="@+id/fragment_title"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:layout_marginBottom="10dp"
@@ -21,10 +23,12 @@
         android:layout_weight="1">
 
         <ViewStub
-            android:id="@+id/omnipod_wizard_base_fragment_content"
+            android:id="@+id/fragment_content"
             android:layout_width="match_parent"
             android:layout_height="wrap_content" />
     </ScrollView>
 
-    <include layout="@layout/omnipod_wizard_nav_buttons" />
+    <include
+        android:id="@+id/nav_buttons_layout"
+        layout="@layout/omnipod_wizard_nav_buttons" />
 </LinearLayout>
\ No newline at end of file
diff --git a/omnipod/src/main/res/layout/omnipod_wizard_nav_buttons.xml b/omnipod/src/main/res/layout/omnipod_wizard_nav_buttons.xml
index abf9a835e2..2619538417 100644
--- a/omnipod/src/main/res/layout/omnipod_wizard_nav_buttons.xml
+++ b/omnipod/src/main/res/layout/omnipod_wizard_nav_buttons.xml
@@ -5,14 +5,14 @@
     android:orientation="horizontal">
 
     <Button
-        android:id="@+id/omnipod_wizard_button_cancel"
+        android:id="@+id/button_cancel"
         android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:layout_weight="1"
         android:text="@string/omnipod_wizard_button_cancel" />
 
     <Button
-        android:id="@+id/omnipod_wizard_button_next"
+        android:id="@+id/button_next"
         android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:layout_weight="1"
diff --git a/omnipod/src/main/res/layout/omnipod_wizard_progress_indication.xml b/omnipod/src/main/res/layout/omnipod_wizard_progress_indication.xml
index cb718d1ceb..74d915bf47 100644
--- a/omnipod/src/main/res/layout/omnipod_wizard_progress_indication.xml
+++ b/omnipod/src/main/res/layout/omnipod_wizard_progress_indication.xml
@@ -5,7 +5,7 @@
     android:orientation="horizontal">
 
     <ProgressBar
-        android:id="@+id/omnipod_wizard_progress_indication"
+        android:id="@+id/progress_indication"
         style="@android:style/Widget.ProgressBar.Horizontal"
         android:layout_width="200dp"
         android:layout_height="wrap_content"