diff --git a/app/src/main/java/info/nightscout/androidaps/plugins/Loop/APSResult.java b/app/src/main/java/info/nightscout/androidaps/plugins/Loop/APSResult.java index 393198d560..bf433d8e59 100644 --- a/app/src/main/java/info/nightscout/androidaps/plugins/Loop/APSResult.java +++ b/app/src/main/java/info/nightscout/androidaps/plugins/Loop/APSResult.java @@ -23,11 +23,14 @@ public class APSResult implements Parcelable { @Override public String toString() { - if (changeRequested) - return MainApp.sResources.getString(R.string.rate) + ": " + DecimalFormatter.to2Decimal(rate) + " U/h\n" + - MainApp.sResources.getString(R.string.duration) + ": " + DecimalFormatter.to0Decimal(duration) + " min\n" + - MainApp.sResources.getString(R.string.reason) + ": " + reason; - else + if (changeRequested) { + if (rate == 0 && duration == 0) + return MainApp.sResources.getString(R.string.canceltemp); + else + return MainApp.sResources.getString(R.string.rate) + ": " + DecimalFormatter.to2Decimal(rate) + " U/h\n" + + MainApp.sResources.getString(R.string.duration) + ": " + DecimalFormatter.to0Decimal(duration) + " min\n" + + MainApp.sResources.getString(R.string.reason) + ": " + reason; + } else return MainApp.sResources.getString(R.string.nochangerequested); } diff --git a/app/src/main/java/info/nightscout/androidaps/plugins/OpenAPSMA/OpenAPSMAPlugin.java b/app/src/main/java/info/nightscout/androidaps/plugins/OpenAPSMA/OpenAPSMAPlugin.java index 7d648d7ec7..321d4ca1d4 100644 --- a/app/src/main/java/info/nightscout/androidaps/plugins/OpenAPSMA/OpenAPSMAPlugin.java +++ b/app/src/main/java/info/nightscout/androidaps/plugins/OpenAPSMA/OpenAPSMAPlugin.java @@ -172,6 +172,9 @@ public class OpenAPSMAPlugin implements PluginBase, APSInterface { DetermineBasalResult determineBasalResult = determineBasalAdapterJS.invoke(); + // Fix bug determine basal + if (determineBasalResult.rate == 0d && determineBasalResult.duration == 0 && !MainApp.getConfigBuilder().isTempBasalInProgress()) determineBasalResult.changeRequested = false; + determineBasalResult.iob = iobTotal; determineBasalAdapterJS.release(); diff --git a/app/src/main/java/info/nightscout/androidaps/plugins/Overview/OverviewFragment.java b/app/src/main/java/info/nightscout/androidaps/plugins/Overview/OverviewFragment.java index 22fd2b81ac..e54e4e6521 100644 --- a/app/src/main/java/info/nightscout/androidaps/plugins/Overview/OverviewFragment.java +++ b/app/src/main/java/info/nightscout/androidaps/plugins/Overview/OverviewFragment.java @@ -202,7 +202,7 @@ public class OverviewFragment extends Fragment { sHandler.post(new Runnable() { @Override public void run() { - acceptTempLayout.setVisibility(View.GONE); + hideTempRecommendation(); PumpEnactResult applyResult = MainApp.getConfigBuilder().applyAPSRequest(finalLastRun.constraintsProcessed); if (applyResult.enacted) { finalLastRun.setByPump = applyResult; @@ -282,6 +282,17 @@ public class OverviewFragment extends Fragment { updateGUIIfVisible(); } + private void hideTempRecommendation() { + Activity activity = getActivity(); + if (activity != null) + activity.runOnUiThread(new Runnable() { + @Override + public void run() { + acceptTempLayout.setVisibility(View.GONE); + } + }); + } + private void updateGUIIfVisible() { Activity activity = getActivity(); if (activity != null) diff --git a/app/src/main/res/layout/overview_fragment.xml b/app/src/main/res/layout/overview_fragment.xml index 7731e7b4d4..13cbce018a 100644 --- a/app/src/main/res/layout/overview_fragment.xml +++ b/app/src/main/res/layout/overview_fragment.xml @@ -4,201 +4,205 @@ android:layout_height="match_parent" tools:context="info.nightscout.androidaps.plugins.Overview.OverviewFragment"> - - + android:layout_height="match_parent"> - - + android:layout_height="match_parent" + android:orientation="vertical"> + android:layout_height="wrap_content" + android:orientation="horizontal"> + + + android:layout_height="match_parent" + android:layout_gravity="top" + android:layout_marginTop="10dp" + android:gravity="center_vertical" + android:orientation="vertical"> + + + + + + + + - + - + + + + + +