From 1932966a637042e57c3ccbaee25cb17d9e991f59 Mon Sep 17 00:00:00 2001
From: Milos Kozak <m.kozak@sysop.cz>
Date: Mon, 13 Jun 2022 17:50:31 +0200
Subject: [PATCH] do not export activities

---
 app/src/main/AndroidManifest.xml          | 102 ++++++++++++++--------
 core/src/main/AndroidManifest.xml         |   9 +-
 dana/src/main/AndroidManifest.xml         |   5 +-
 danars/src/main/AndroidManifest.xml       |   6 +-
 diaconn/src/main/AndroidManifest.xml      |   9 +-
 insight/src/main/AndroidManifest.xml      |   6 +-
 medtronic/src/main/AndroidManifest.xml    |  12 ++-
 omnipod-dash/src/main/AndroidManifest.xml |  19 ++--
 omnipod-eros/src/main/AndroidManifest.xml |  19 ++--
 rileylink/src/main/AndroidManifest.xml    |  12 +--
 10 files changed, 129 insertions(+), 70 deletions(-)

diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 8cb2f771fb..8fb0dea2f6 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:tools="http://schemas.android.com/tools">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
     <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED" />
     <uses-permission android:name="android.permission.BLUETOOTH" />
@@ -47,7 +46,7 @@
         android:restoreAnyVersion="true"
         android:roundIcon="${appIconRound}"
         android:supportsRtl="true"
-        android:theme="@style/AppTheme.Launcher" >
+        android:theme="@style/AppTheme.Launcher">
 
         <meta-data
             android:name="com.google.android.gms.version"
@@ -64,7 +63,7 @@
 
         <receiver
             android:name=".widget.Widget"
-            android:exported="true" >
+            android:exported="true">
             <intent-filter>
                 <action android:name="android.appwidget.action.APPWIDGET_UPDATE" />
             </intent-filter>
@@ -82,69 +81,86 @@
             android:name="com.google.android.gms.car.application"
             android:resource="@xml/automotive_app_desc" />
 
-        <activity android:name=".MainActivity"
-            android:theme="@style/AppTheme"
-            android:exported="true">
+        <activity
+            android:name=".MainActivity"
+            android:exported="true"
+            android:theme="@style/AppTheme">
             <intent-filter>
                 <action android:name="android.intent.action.VIEW" />
                 <action android:name="android.intent.action.MAIN" />
+
                 <category android:name="android.intent.category.LAUNCHER" />
             </intent-filter>
         </activity>
-        <activity android:name=".activities.PreferencesActivity" />
-        <activity android:name=".plugins.general.overview.activities.QuickWizardListActivity"
-            android:theme="@style/AppTheme"
-            android:exported="false">
+        <activity
+            android:name=".activities.PreferencesActivity"
+            android:exported="false" />
+        <activity
+            android:name=".plugins.general.overview.activities.QuickWizardListActivity"
+            android:exported="false"
+            android:theme="@style/AppTheme">
             <intent-filter>
                 <action android:name="info.nightscout.androidaps.plugins.general.overview.activities.QuickWizardListActivity" />
 
                 <category android:name="android.intent.category.DEFAULT" />
             </intent-filter>
         </activity>
-        <activity android:name=".plugins.general.maintenance.activities.PrefImportListActivity"
+        <activity
+            android:name=".plugins.general.maintenance.activities.PrefImportListActivity"
+            android:exported="false"
             android:theme="@style/AppTheme" />
-        <activity android:name=".activities.HistoryBrowseActivity"
+        <activity
+            android:name=".activities.HistoryBrowseActivity"
+            android:exported="false"
             android:theme="@style/AppTheme" />
-        <activity android:name=".activities.TreatmentsActivity"
+        <activity
+            android:name=".activities.TreatmentsActivity"
+            android:exported="false"
             android:theme="@style/AppTheme" />
-        <activity android:name=".activities.SurveyActivity"
+        <activity
+            android:name=".activities.SurveyActivity"
+            android:exported="false"
             android:theme="@style/AppTheme" />
-        <activity android:name=".activities.ProfileHelperActivity"
+        <activity
+            android:name=".activities.ProfileHelperActivity"
+            android:exported="false"
             android:theme="@style/AppTheme" />
-        <activity android:name=".activities.StatsActivity"
+        <activity
+            android:name=".activities.StatsActivity"
+            android:exported="false"
             android:theme="@style/AppTheme" />
 
         <!-- Receive new BG readings from other local apps -->
         <receiver
-                android:name=".receivers.DataReceiver"
-                android:enabled="true"
-                android:exported="true">
+            android:name=".receivers.DataReceiver"
+            android:enabled="true"
+            android:exported="true">
             <intent-filter>
                 <!-- Receiver from xDrip -->
-                <action android:name="com.eveningoutpost.dexdrip.BgEstimate"/>
+                <action android:name="com.eveningoutpost.dexdrip.BgEstimate" />
                 <!-- Receiver from 640g uploader -->
-                <action android:name="com.eveningoutpost.dexdrip.NS_EMULATOR"/>
+                <action android:name="com.eveningoutpost.dexdrip.NS_EMULATOR" />
                 <!-- Receiver from glimp -->
-                <action android:name="it.ct.glicemia.ACTION_GLUCOSE_MEASURED"/>
+                <action android:name="it.ct.glicemia.ACTION_GLUCOSE_MEASURED" />
                 <!-- Receiver from Dexcom -->
-                <action android:name="com.dexcom.cgm.EXTERNAL_BROADCAST"/>
+                <action android:name="com.dexcom.cgm.EXTERNAL_BROADCAST" />
                 <!-- Receiver from Poctech -->
-                <action android:name="com.china.poctech.data"/>
+                <action android:name="com.china.poctech.data" />
                 <!-- Receiver from Tomato -->
-                <action android:name="com.fanqies.tomatofn.BgEstimate"/>
+                <action android:name="com.fanqies.tomatofn.BgEstimate" />
                 <!-- Receiver from GlucoRx Aidex -->
-                <action android:name="com.microtechmd.cgms.aidex.action.BgEstimate"/>
+                <action android:name="com.microtechmd.cgms.aidex.action.BgEstimate" />
             </intent-filter>
         </receiver>
 
         <!-- Receive new SMS messages -->
         <receiver
-                android:name=".receivers.SmsReceiver"
-                android:enabled="true"
-                android:exported="true"
-                android:permission="android.permission.BROADCAST_SMS">
+            android:name=".receivers.SmsReceiver"
+            android:enabled="true"
+            android:exported="true"
+            android:permission="android.permission.BROADCAST_SMS">
             <intent-filter>
-                <action android:name="android.provider.Telephony.SMS_RECEIVED"/>
+                <action android:name="android.provider.Telephony.SMS_RECEIVED" />
             </intent-filter>
         </receiver>
 
@@ -211,15 +227,23 @@
         <activity
             android:name=".setupwizard.SetupWizardActivity"
             android:configChanges="orientation|keyboardHidden|screenSize"
-            android:theme="@style/AppTheme"
-            android:label="@string/title_activity_setup_wizard" />
+            android:exported="false"
+            android:label="@string/title_activity_setup_wizard"
+            android:theme="@style/AppTheme" />
 
         <activity
             android:name=".activities.SingleFragmentActivity"
+            android:exported="false"
             android:theme="@style/AppTheme" />
-        <activity android:name=".plugins.general.maintenance.activities.LogSettingActivity" />
-        <activity android:name=".activities.RequestDexcomPermissionActivity" />
-        <activity android:name=".plugins.general.smsCommunicator.activities.SmsCommunicatorOtpActivity">
+        <activity
+            android:name=".plugins.general.maintenance.activities.LogSettingActivity"
+            android:exported="false" />
+        <activity
+            android:name=".activities.RequestDexcomPermissionActivity"
+            android:exported="false" />
+        <activity
+            android:name=".plugins.general.smsCommunicator.activities.SmsCommunicatorOtpActivity"
+            android:exported="false">
             <intent-filter>
                 <action android:name="info.nightscout.androidaps.plugins.general.smsCommunicator.activities.SmsCommunicatorOtpActivity" />
 
@@ -227,7 +251,9 @@
             </intent-filter>
         </activity>
 
-        <uses-library android:name="org.apache.http.legacy" android:required="false"/>
+        <uses-library
+            android:name="org.apache.http.legacy"
+            android:required="false" />
 
     </application>
 
diff --git a/core/src/main/AndroidManifest.xml b/core/src/main/AndroidManifest.xml
index 6cd58651e5..0f37944ddb 100644
--- a/core/src/main/AndroidManifest.xml
+++ b/core/src/main/AndroidManifest.xml
@@ -8,14 +8,17 @@
 
     <uses-permission android:name="android.permission.BLUETOOTH_ADMIN" />
 
-    <application
-        android:supportsRtl="true">
-        <activity android:name="info.nightscout.androidaps.activities.TDDStatsActivity" />
+    <application android:supportsRtl="true">
+        <activity
+            android:name="info.nightscout.androidaps.activities.TDDStatsActivity"
+            android:exported="false" />
         <activity
             android:name="info.nightscout.androidaps.activities.BolusProgressHelperActivity"
+            android:exported="false"
             android:theme="@style/Theme.MaterialComponents.Translucent" />
         <activity
             android:name="info.nightscout.androidaps.activities.ErrorHelperActivity"
+            android:exported="false"
             android:theme="@style/Theme.MaterialComponents.Translucent" />
 
     </application>
diff --git a/dana/src/main/AndroidManifest.xml b/dana/src/main/AndroidManifest.xml
index af4b1f4b1e..3960154ebf 100644
--- a/dana/src/main/AndroidManifest.xml
+++ b/dana/src/main/AndroidManifest.xml
@@ -1,12 +1,13 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
-    <application
-        android:supportsRtl="true">
+    <application android:supportsRtl="true">
         <activity
             android:name="info.nightscout.androidaps.dana.activities.DanaHistoryActivity"
+            android:exported="false"
             android:theme="@style/AppTheme" />
         <activity
             android:name="info.nightscout.androidaps.dana.activities.DanaUserOptionsActivity"
+            android:exported="false"
             android:theme="@style/AppTheme" />
     </application>
 </manifest>
diff --git a/danars/src/main/AndroidManifest.xml b/danars/src/main/AndroidManifest.xml
index c0a4377e25..c3ef8bc727 100644
--- a/danars/src/main/AndroidManifest.xml
+++ b/danars/src/main/AndroidManifest.xml
@@ -6,7 +6,9 @@
     <uses-permission android:name="android.permission.BLUETOOTH_CONNECT" />
 
     <application>
-        <activity android:name="info.nightscout.androidaps.danars.activities.BLEScanActivity">
+        <activity
+            android:name="info.nightscout.androidaps.danars.activities.BLEScanActivity"
+            android:exported="false">
             <intent-filter>
                 <action android:name="info.nightscout.androidaps.plugins.PumpDanaRS.activities.BLEScanActivity" />
                 <category android:name="android.intent.category.DEFAULT" />
@@ -14,9 +16,11 @@
         </activity>
         <activity
             android:name="info.nightscout.androidaps.danars.activities.PairingHelperActivity"
+            android:exported="false"
             android:launchMode="singleTask" />
         <activity
             android:name="info.nightscout.androidaps.danars.activities.EnterPinActivity"
+            android:exported="false"
             android:launchMode="singleTask" />
 
         <service
diff --git a/diaconn/src/main/AndroidManifest.xml b/diaconn/src/main/AndroidManifest.xml
index b4487ffda6..837b1eae29 100644
--- a/diaconn/src/main/AndroidManifest.xml
+++ b/diaconn/src/main/AndroidManifest.xml
@@ -6,18 +6,19 @@
     <uses-permission android:name="android.permission.BLUETOOTH_CONNECT" />
     <uses-permission android:name="android.permission.BLUETOOTH_SCAN" />
 
-    <application
-        android:supportsRtl="true">
+    <application android:supportsRtl="true">
         <activity
             android:name="info.nightscout.androidaps.diaconn.activities.DiaconnG8HistoryActivity"
+            android:exported="false"
             android:theme="@style/AppTheme" />
         <activity
             android:name="info.nightscout.androidaps.diaconn.activities.DiaconnG8UserOptionsActivity"
+            android:exported="false"
             android:theme="@style/AppTheme" />
         <activity
             android:name="info.nightscout.androidaps.diaconn.activities.DiaconnG8BLEScanActivity"
-            android:theme="@style/AppTheme"
-            android:exported="false">
+            android:exported="false"
+            android:theme="@style/AppTheme">
             <intent-filter>
                 <action android:name="info.nightscout.androidaps.plugins.PumpDiaconnG8.activities.DiaconnG8BLEScanActivity" />
                 <category android:name="android.intent.category.DEFAULT" />
diff --git a/insight/src/main/AndroidManifest.xml b/insight/src/main/AndroidManifest.xml
index d8d973e0b3..d125d192f6 100644
--- a/insight/src/main/AndroidManifest.xml
+++ b/insight/src/main/AndroidManifest.xml
@@ -6,19 +6,23 @@
     <uses-permission android:name="android.permission.BLUETOOTH_CONNECT" />
     <uses-permission android:name="android.permission.BLUETOOTH_SCAN" />
     <uses-permission android:name="android.permission.VIBRATE" />
+
     <application>
         <activity
             android:name="info.nightscout.androidaps.plugins.pump.insight.activities.InsightPairingActivity"
+            android:exported="false"
             android:label="@string/insight_pairing"
             android:theme="@style/AppTheme" />
         <activity
             android:name="info.nightscout.androidaps.plugins.pump.insight.activities.InsightAlertActivity"
-            android:label="@string/pump_alert"
             android:excludeFromRecents="true"
+            android:exported="false"
+            android:label="@string/pump_alert"
             android:launchMode="singleInstance"
             android:theme="@style/InsightAlertDialog" />
         <activity
             android:name="info.nightscout.androidaps.plugins.pump.insight.activities.InsightPairingInformationActivity"
+            android:exported="false"
             android:label="@string/pairing_information"
             android:theme="@style/AppTheme" />
 
diff --git a/medtronic/src/main/AndroidManifest.xml b/medtronic/src/main/AndroidManifest.xml
index 6c2ac78309..935c304195 100644
--- a/medtronic/src/main/AndroidManifest.xml
+++ b/medtronic/src/main/AndroidManifest.xml
@@ -1,15 +1,19 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
-    <application
-        android:supportsRtl="true">
+    <application android:supportsRtl="true">
         <service
             android:name=".service.RileyLinkMedtronicService"
             android:enabled="true"
             android:exported="false" />
 
-        <activity android:name=".dialog.MedtronicHistoryActivity"  android:theme="@style/AppTheme" />
+        <activity
+            android:name=".dialog.MedtronicHistoryActivity"
+            android:exported="false"
+            android:theme="@style/AppTheme" />
 
-        <uses-library android:name="org.apache.http.legacy" android:required="false"/>
+        <uses-library
+            android:name="org.apache.http.legacy"
+            android:required="false" />
     </application>
 
 </manifest>
diff --git a/omnipod-dash/src/main/AndroidManifest.xml b/omnipod-dash/src/main/AndroidManifest.xml
index ee32e26eea..0408c54440 100644
--- a/omnipod-dash/src/main/AndroidManifest.xml
+++ b/omnipod-dash/src/main/AndroidManifest.xml
@@ -7,11 +7,18 @@
     <uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
     <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
 
-    <application
-        android:supportsRtl="true">
-        <activity android:name=".ui.wizard.activation.DashPodActivationWizardActivity" />
-        <activity android:name=".ui.wizard.deactivation.DashPodDeactivationWizardActivity" />
-        <activity android:name=".ui.DashPodManagementActivity" />
-        <activity android:name=".ui.DashPodHistoryActivity" />
+    <application android:supportsRtl="true">
+        <activity
+            android:name=".ui.wizard.activation.DashPodActivationWizardActivity"
+            android:exported="false" />
+        <activity
+            android:name=".ui.wizard.deactivation.DashPodDeactivationWizardActivity"
+            android:exported="false" />
+        <activity
+            android:name=".ui.DashPodManagementActivity"
+            android:exported="false" />
+        <activity
+            android:name=".ui.DashPodHistoryActivity"
+            android:exported="false" />
     </application>
 </manifest>
\ No newline at end of file
diff --git a/omnipod-eros/src/main/AndroidManifest.xml b/omnipod-eros/src/main/AndroidManifest.xml
index 02eb4fc2fa..b036e15038 100644
--- a/omnipod-eros/src/main/AndroidManifest.xml
+++ b/omnipod-eros/src/main/AndroidManifest.xml
@@ -1,15 +1,22 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
-    <application
-        android:supportsRtl="true">
+    <application android:supportsRtl="true">
         <service
             android:name=".rileylink.service.RileyLinkOmnipodService"
             android:enabled="true"
             android:exported="true" />
 
-        <activity android:name=".ui.wizard.activation.ErosPodActivationWizardActivity" />
-        <activity android:name=".ui.wizard.deactivation.ErosPodDeactivationWizardActivity" />
-        <activity android:name=".ui.ErosPodManagementActivity" />
-        <activity android:name=".ui.ErosPodHistoryActivity" />
+        <activity
+            android:name=".ui.wizard.activation.ErosPodActivationWizardActivity"
+            android:exported="false" />
+        <activity
+            android:name=".ui.wizard.deactivation.ErosPodDeactivationWizardActivity"
+            android:exported="false" />
+        <activity
+            android:name=".ui.ErosPodManagementActivity"
+            android:exported="false" />
+        <activity
+            android:name=".ui.ErosPodHistoryActivity"
+            android:exported="false" />
     </application>
 </manifest>
\ No newline at end of file
diff --git a/rileylink/src/main/AndroidManifest.xml b/rileylink/src/main/AndroidManifest.xml
index 17c2a20a5e..684a90fcf6 100644
--- a/rileylink/src/main/AndroidManifest.xml
+++ b/rileylink/src/main/AndroidManifest.xml
@@ -12,9 +12,10 @@
     <uses-permission android:name="android.permission.LOCAL_MAC_ADDRESS" />
 
     <application>
-        <activity android:name="info.nightscout.androidaps.plugins.pump.common.dialog.RileyLinkBLEConfigActivity"
-            android:theme="@style/AppTheme"
-            android:exported="false">
+        <activity
+            android:name="info.nightscout.androidaps.plugins.pump.common.dialog.RileyLinkBLEConfigActivity"
+            android:exported="false"
+            android:theme="@style/AppTheme">
             <intent-filter>
                 <action android:name="info.nightscout.androidaps.plugins.PumpCommon.dialog.RileyLinkBLEConfigActivity" />
                 <category android:name="android.intent.category.DEFAULT" />
@@ -23,8 +24,9 @@
 
         <activity
             android:name="info.nightscout.androidaps.plugins.pump.common.hw.rileylink.dialog.RileyLinkStatusActivity"
-            android:theme="@style/AppTheme"
-            android:label="@string/title_activity_rileylink_settings" />
+            android:exported="false"
+            android:label="@string/title_activity_rileylink_settings"
+            android:theme="@style/AppTheme" />
     </application>
 
 </manifest>