From 0fad1bc6c7dd0ef94b7b4de791616db6a7b123ad Mon Sep 17 00:00:00 2001 From: Andrei Vereha Date: Wed, 21 Apr 2021 22:54:47 +0200 Subject: [PATCH] add comment --- .../plugins/pump/omnipod/dash/OmnipodDashPumpPlugin.kt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/omnipod-dash/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/dash/OmnipodDashPumpPlugin.kt b/omnipod-dash/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/dash/OmnipodDashPumpPlugin.kt index b063b058d5..f317c3d65b 100644 --- a/omnipod-dash/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/dash/OmnipodDashPumpPlugin.kt +++ b/omnipod-dash/src/main/java/info/nightscout/androidaps/plugins/pump/omnipod/dash/OmnipodDashPumpPlugin.kt @@ -466,6 +466,9 @@ class OmnipodDashPumpPlugin @Inject constructor( }, onError = { throwable -> aapsLogger.error(LTag.PUMP, "Error executing command", throwable) + // Here we assume that onError will be called only BEFORE we manage to send a command + // If it gets called later, we will have the command as "not sent" in history and will not try to + // get it's final status, even if it was send podStateManager.resetActiveCommand() source.onSuccess( PumpEnactResult(injector).success(false).enacted(false).comment(throwable.message)